Remove problematic similar and zero methods for MatRingElem#2283
Remove problematic similar and zero methods for MatRingElem#2283fingolfin wants to merge 2 commits into
similar and zero methods for MatRingElem#2283Conversation
fingolfin
changed the title
similar + zero methods for MatRingElem
fingolfin
force-pushed
the
mh/deprecate-matring
branch
from
647baca to
c454801
Compare
|
Turns out this is used in e.g. |
fingolfin
force-pushed
the
mh/deprecate-matring
branch
from
c454801 to
701387e
Compare
fingolfin
changed the title
similar + zero methods for MatRingElemsimilar and zero methods for MatRingElem
|
What is the status? Is this waiting for #2280? |
fingolfin
force-pushed
the
mh/deprecate-matring
branch
from
ff373f0 to
2aa304e
Compare
|
I am not sure. I've rebased it now, let's see what CI says |
|
ci is very unhappy |
fingolfin
force-pushed
the
mh/deprecate-matring
branch
from
2aa304e to
581aad4
Compare
|
Had to give |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2283 +/- ##
==========================================
- Coverage 88.12% 88.12% -0.01%
==========================================
Files 130 130
Lines 32972 32970 -2
==========================================
- Hits 29057 29054 -3
- Misses 3915 3916 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| return rank, p, L, U | ||
| end | ||
|
|
||
| function lu(A::MatRingElem{T}, P = SymmetricGroup(nrows(A))) where {T <: FieldElement} |
There was a problem hiding this comment.
this method should move to a file for MatRings
| return rank, d, p, L, U | ||
| end | ||
|
|
||
| function fflu(A::MatRingElem{T}, P = SymmetricGroup(nrows(A))) where {T <: RingElement} |
There was a problem hiding this comment.
this method should move to a file for MatRings
3 participants
Argh, forgot about these, and now 0.48.0 is out. Ah well, perhaps better this way, so that we can get CI tests for this (once everything has updated to 0.48.0).