Skip to content

is_unit in ring interface tests contradicts documentation #2360

@lgoettgens

Description

@lgoettgens

According to https://nemocas.github.io/AbstractAlgebra.jl/stable/ring_interface/#Optional-basic-manipulation-functionality, is_unit is an optional method to implement for a Ring. But the conformance tests still require that it is implemented and does sensible things when provided the zero or one of the ring.

Can we just remove these two lines? @fingolfin

cc @KevinKuehn

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions