fix #705: don not group and nest attributes when both preserveOrder and attributesGroupName are set

Author: amitguptagwl

docs/v4, v5/2.XMLparseOptions.md

@@ -154,6 +154,8 @@ Output
 }
 ```
 
+If `preserveOrder` is set to `true`, `attributesGroupName` is ignored (because attributes are already preserved in their original order within the node).
+
 ## attributeNamePrefix
 
 To recognize attributes in the JS object separately. You can prepend some string with each attribute name.

spec/attr_spec.js

@@ -330,4 +330,27 @@ id="7" data="foo bar" bug="true"/>`;
         //console.log(JSON.stringify(result,null,4));
         expect(result).toEqual(expected);
     });
+
+    it("should preser over with attribute group", function () {
+        const xmlData = "<rootNode  abc='23' />";
+        const expected = [
+            {
+                "rootNode": [],
+                ":@": {
+                    "@_abc": "23"
+                }
+            }
+        ]
+
+        const options = {
+            attributesGroupName: ':@',
+            preserveOrder: true,
+            ignoreAttributes: false,
+        }
+        const parser = new XMLParser(options);
+
+        const result = parser.parse(xmlData);
+        // console.log(JSON.stringify(result, null, 4));
+        expect(result).toEqual(expected);
+    });
 });

src/xmlparser/OrderedObjParser.js

@@ -269,7 +269,7 @@ function buildAttributesMap(attrStr, jPath, tagName, force = false) {
 
     if (!hasAttrs) return;
 
-    if (options.attributesGroupName) {
+    if (options.attributesGroupName && !options.preserveOrder) {
       const attrCollection = {};
       attrCollection[options.attributesGroupName] = attrs;
       return attrCollection;