Walk Comfort Index (WCI) Script Refactor

[robfitzgerald]

The WCI script is a good starting point for designing a Bike Level of Traffic Stress (LTS) script but the script will need a refactor in order to make some of the common logic reusable. In particular, we should look to address code style issues such as:

• using match over if/then
• preferring immutable values over mutable
• encapsulating procedures into functions
• avoiding clones of record types, using references

[admrtin]

Initial thoughts: scaffolding for refactor of WCI scripts and preparing objects/routines for LTS implementation:

app/
├── mod.rs
└── comfort/
    ├── mod.rs
    ├── wci/                  // unique WCI logic
    │   └── mod.rs
    ├── lts/                  // unique LTS logic
    │   └── mod.rs
    ├── <shared_typ_1>.rs     // one file per shared type
    ├── ...
    ├── <shared_typ_n>.rs
    ├── <shared_fn_1>.rs      // one file per shared routine
    ├── ...
    └── <shared_fn_n>.rs

The current functionality is in rust/bambam-osm/src/app. I'm not sure if this is the right home. FWIW, on my first search the WCI scripts were a little hard to find.

We should also consider merging shared fn's into a single file called comfort_utils.rs or something along those lines.

[robfitzgerald]

let's change comfort to network as it will eventually include 3 forms of network modification logic that isn't necessarily tied to the notion of comfort. let's move shared_fn_{1..n} into a directory either named util or common or something similar, up to you. sounds like a plan!

[robfitzgerald]

closed via #157