The Prometheus counter in pkg/metrics/metrics.go is named aswa_checks_total with help text "Failed synthetic test.", but it is only ever incremented for failing checks (see IncrementFailedTestsCounter, called from RunSyntheticTests). The name implies it counts all checks, which is misleading for anyone querying it.
Proposed: rename to something like aswa_failed_checks_total and update the help text. Note this is a metric-name change, so any dashboards/alerts referencing aswa_checks_total must be updated in lockstep.
The Prometheus counter in
pkg/metrics/metrics.gois namedaswa_checks_totalwith help text"Failed synthetic test.", but it is only ever incremented for failing checks (see IncrementFailedTestsCounter, called fromRunSyntheticTests). The name implies it counts all checks, which is misleading for anyone querying it.Proposed: rename to something like a
swa_failed_checks_totaland update the help text. Note this is a metric-name change, so any dashboards/alerts referencingaswa_checks_totalmust be updated in lockstep.