From 8fc517e3256ffbd606225a8cac3b96f50f570a9e Mon Sep 17 00:00:00 2001 From: Hamid Asayesh Date: Wed, 10 Jun 2026 18:37:46 -0700 Subject: [PATCH] Update IB enablement guidance ## Type of Change - [ ] **Add** - New feature or capability - [ ] **Change** - Changes in existing functionality - [ ] **Fix** - Bug fixes - [ ] **Remove** - Removed features or deprecated functionality - [X] **Internal** - Internal changes (refactoring, tests, docs, etc.) ## Description Clarifies Infiniband enablement guidance by documenting that `[ib_config]` starts the IB fabric manager and IB fabric monitor, removes the separate `[ib_fabric_monitor]` enablement example, and adds commented UFM endpoint and PKey range examples to the Helm prereq values. ## Related Issues (Optional) ## Breaking Changes - [ ] This PR contains breaking changes ## Testing - [ ] Unit tests added/updated - [ ] Integration tests added/updated - [ ] Manual testing performed - [X] No testing required (docs and commented configuration examples only) ## Additional Notes Signed-off-by: Hamid Asayesh --- docs/playbooks/ib_runbook.md | 11 ++++------- helm-prereqs/values/nico-core.yaml | 13 +++++++++---- 2 files changed, 13 insertions(+), 11 deletions(-) diff --git a/docs/playbooks/ib_runbook.md b/docs/playbooks/ib_runbook.md index c2656cb58b..6bec812878 100644 --- a/docs/playbooks/ib_runbook.md +++ b/docs/playbooks/ib_runbook.md @@ -489,16 +489,13 @@ the fabric ID `default` will be accepted here. Update the configmap `nico-api-site-config-files` to enable Infiniband features as follows: -```toml -[ib_config] -enabled = true -``` - -To enable the monitor of IB, update the configmap `nico-api-site-config-files` as follows: +When `enabled = true`, NICo starts the IB fabric manager and IB fabric monitor. ```toml -[ib_fabric_monitor] +[ib_config] enabled = true +# Optional: defaults to "60s" +# fabric_monitor_run_interval = "60s" ``` #### Restart nico-api diff --git a/helm-prereqs/values/nico-core.yaml b/helm-prereqs/values/nico-core.yaml index 18abd218d9..6ea98df891 100644 --- a/helm-prereqs/values/nico-core.yaml +++ b/helm-prereqs/values/nico-core.yaml @@ -175,10 +175,15 @@ nico-api: # InfiniBand (leave enabled=false if no IB fabric at this site) # ----------------------------------------------------------------------- [ib_config] - enabled = false - - [ib_fabric_monitor] - enabled = false + enabled = false # EXAMPLE - replace false with true to enable IB + + # Then uncomment the following ib_fabrics.default lines, + # replace the example endpoint with your UFM VIP address, and configure + # a start-end PKey range. For sharded sites, ensure the range does not + # overlap any other shard. + # [ib_fabrics.default] + # endpoints = ["https://10.180.126.181:443"] # EXAMPLE - replace with your UFM endpoint + # pkeys = [{ start = "9000", end = "11000" }] # EXAMPLE - replace with your site PKey range # ----------------------------------------------------------------------- # Firmware management