Skip to content

evals: add 3 C API evals for cuopt-numerical-optimization-api-c skill#1417

Merged
rapids-bot[bot] merged 3 commits into
mainfrom
add-c-api-evals-numerical-optimization
Jun 10, 2026
Merged

evals: add 3 C API evals for cuopt-numerical-optimization-api-c skill#1417
rapids-bot[bot] merged 3 commits into
mainfrom
add-c-api-evals-numerical-optimization

Conversation

@rgsl888prabhu

@rgsl888prabhu rgsl888prabhu commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Adds 3 new evals to skills/cuopt-numerical-optimization-api-c/evals/evals.json (was 1, now 4), all grounded in skill-specific C API content from SKILL.md and references/examples.md.

Adds numopt-c-eval-002, 003, 004 covering skill-specific C API content:
- eval-002: wrong parameter function name (cuOptSetIntParameter vs
  cuOptSetIntegerParameter) — documented gotcha in references/examples.md
- eval-003: CSR matrix construction for cuOptCreateRangedProblem
- eval-004: QP restrictions (minimize-only, continuous-only, PSD Q)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@rgsl888prabhu rgsl888prabhu requested a review from a team as a code owner June 10, 2026 15:00
@rgsl888prabhu rgsl888prabhu requested a review from Iroy30 June 10, 2026 15:00
@rgsl888prabhu rgsl888prabhu self-assigned this Jun 10, 2026
@rgsl888prabhu rgsl888prabhu added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Jun 10, 2026
@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: e4589c09-ac2f-4594-87ee-0ea082344343

📥 Commits

Reviewing files that changed from the base of the PR and between 99ad294 and 7a74656.

📒 Files selected for processing (3)
  • skills/cuopt-numerical-optimization-api-c/BENCHMARK.md
  • skills/cuopt-numerical-optimization-api-c/skill-card.md
  • skills/cuopt-numerical-optimization-api-c/skill.oms.sig
✅ Files skipped from review due to trivial changes (2)
  • skills/cuopt-numerical-optimization-api-c/BENCHMARK.md
  • skills/cuopt-numerical-optimization-api-c/skill-card.md

📝 Walkthrough

Walkthrough

Three evaluation test cases are added to the cuOpt C API skills evaluation file. The changes cover parameter setter function identification, CSR constraint matrix representation, and quadratic programming restrictions in the cuOpt C API.

Changes

cuOpt C API Evaluation Coverage

Layer / File(s) Summary
API evaluation cases
skills/cuopt-numerical-optimization-api-c/evals/evals.json
Three evaluation items added: (1) identifying the correct parameter-setter function for float parameters like CUOPT_TIME_LIMIT and listing the three available functions by type; (2) specifying CSR array representation for a small 2-constraint/2-variable LP with explanation of array semantics; (3) documenting QP restrictions including integer QP unsupported status, minimization requirement, and continuous-variable requirement.
Benchmark metadata update
skills/cuopt-numerical-optimization-api-c/BENCHMARK.md
Updated evaluation date, execution environment, dataset/task counts, added security signal, and refreshed result metrics and Tier 1 summary.
Skill-card and references
skills/cuopt-numerical-optimization-api-c/skill-card.md
Reworded use-case to reference embedding LP/MILP/QP into C/C++; consolidated references, adjusted Skill Output metadata, added security signal, and updated evaluation results table.
Sigstore DSSE bundle
skills/cuopt-numerical-optimization-api-c/skill.oms.sig
Replaced DSSE bundle payload digests and signature with updated SHA-256 digests and a new signature entry.

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • tmckayus
  • mlubin
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: adding 3 new C API evaluations to the cuopt skill's evals.json file.
Description check ✅ Passed The description clearly relates to the changeset, explaining that 3 new evals were added to evals.json (increasing from 1 to 4) grounded in C API content.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch add-c-api-evals-numerical-optimization

Comment @coderabbitai help to get the list of available commands and usage tips.

@rgsl888prabhu

Copy link
Copy Markdown
Collaborator Author

/nvskills-ci

1 similar comment
@rgsl888prabhu

Copy link
Copy Markdown
Collaborator Author

/nvskills-ci

@rgsl888prabhu

Copy link
Copy Markdown
Collaborator Author

/nvskills-ci

Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Jun 10, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@rgsl888prabhu

Copy link
Copy Markdown
Collaborator Author

/ok to test 7a74656

@rgsl888prabhu

Copy link
Copy Markdown
Collaborator Author

/merge

@rapids-bot rapids-bot Bot merged commit c99a5ce into main Jun 10, 2026
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants