From c75a78c130e2efa7e6d68360812ac9c9f460f48e Mon Sep 17 00:00:00 2001 From: "Xin He (SW-GPU)" <200704525+xinhe-nv@users.noreply.github.com> Date: Fri, 24 Jul 2026 11:28:13 +0800 Subject: [PATCH 1/5] update coderabbit prompt Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com> --- .coderabbit.yaml | 23 ++++++++++------------- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/.coderabbit.yaml b/.coderabbit.yaml index 2caf9db60128..76d975ac884d 100644 --- a/.coderabbit.yaml +++ b/.coderabbit.yaml @@ -23,24 +23,21 @@ reviews: auto_title_instructions: 'Format: "[] ". Category must be one of: fix, feat, doc, infra, style, refactor, perf, test, chore, revert. Enclose the category in square brackets. Title should be concise (<= 60 chars). Example: "[feat] Add logit_bias support".' commit_status: false high_level_summary_instructions: | - Always produce two review sections in the summary: + Produce two sections: **Dev Engineer Review** - Review all changes for correctness and consistency, including: - - Code changes: correctness, performance, API consistency (CODING_GUIDELINES.md), error handling, regressions. - - Config files: valid values, no typos, consistency with related configs, no unintended scope changes. - - Test list files (test-db/, qa/, waives.txt): correct format, valid test paths, appropriate bug references, no duplicates. + Correctness, performance, API consistency (CODING_GUIDELINES.md), error handling, regressions. **QA Engineer Review** - Always include this section when any files under tests/ are touched. - For test-list-only changes (only tests/integration/test_lists/ files): - - List which test-db/ or qa/ files were modified and what entries were added or removed. - - Verdict: "needs follow-up" if CBTS coverage data is unavailable, otherwise "sufficient" or "insufficient". - For test-code changes (files outside tests/integration/test_lists/): - - List test functions added, modified, or removed. - - State whether each is covered in tests/integration/test_lists/ (test-db/ for CI, qa/ for manual QA). - - Verdict: sufficient, insufficient, or needs follow-up. + Test coverage verdict: sufficient, insufficient, or needs follow-up. If no test files are touched, write "No test changes." + walkthrough_instructions: | + For each changed file, include a concise QA perspective: + - For test files (tests/**): note what the test covers and whether it is listed in + tests/integration/test_lists/test-db/ (CI) or tests/integration/test_lists/qa/ (manual QA). + - For source files: note any observable behavior changes a QA engineer should verify + (new code paths, changed APIs, altered defaults, removed functionality). + Keep each entry to 1-2 sentences; omit if no QA-relevant impact. collapse_walkthrough: false assess_linked_issues: true related_issues: true From ac21baaefdbdbecf00527ca3eecaccb3d36e4bc7 Mon Sep 17 00:00:00 2001 From: "Xin He (SW-GPU)" <200704525+xinhe-nv@users.noreply.github.com> Date: Fri, 24 Jul 2026 11:41:58 +0800 Subject: [PATCH 2/5] update coderabbit prompt Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com> --- .coderabbit.yaml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.coderabbit.yaml b/.coderabbit.yaml index 76d975ac884d..07dd74b65c00 100644 --- a/.coderabbit.yaml +++ b/.coderabbit.yaml @@ -29,8 +29,11 @@ reviews: Correctness, performance, API consistency (CODING_GUIDELINES.md), error handling, regressions. **QA Engineer Review** - Test coverage verdict: sufficient, insufficient, or needs follow-up. - If no test files are touched, write "No test changes." + Assess whether the changed code is covered by tests outside this PR + (existing entries in tests/integration/test_lists/test-db/ for CI or + tests/integration/test_lists/qa/ for manual QA). + Coverage verdict: sufficient, insufficient, or needs follow-up. + If no source files are touched, write "No source changes requiring QA coverage." walkthrough_instructions: | For each changed file, include a concise QA perspective: - For test files (tests/**): note what the test covers and whether it is listed in From 0c7ade5030df0b7af3bc1f5a290604ada619fbf0 Mon Sep 17 00:00:00 2001 From: "Xin He (SW-GPU)" <200704525+xinhe-nv@users.noreply.github.com> Date: Fri, 24 Jul 2026 15:20:30 +0800 Subject: [PATCH 3/5] update coderabbit prompt Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com> --- .coderabbit.yaml | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/.coderabbit.yaml b/.coderabbit.yaml index 07dd74b65c00..2314dddd8ff4 100644 --- a/.coderabbit.yaml +++ b/.coderabbit.yaml @@ -32,12 +32,16 @@ reviews: Assess whether the changed code is covered by tests outside this PR (existing entries in tests/integration/test_lists/test-db/ for CI or tests/integration/test_lists/qa/ for manual QA). - Coverage verdict: sufficient, insufficient, or needs follow-up. - If no source files are touched, write "No source changes requiring QA coverage." + If no test files are modified, write "No test changes." + When CBTS artifacts are available, the verdict must cite their results: + "sufficient" only when the relevant coverage passes; otherwise "insufficient" + with the failing or missing evidence identified. + When CBTS artifacts are unavailable, use "needs follow-up". walkthrough_instructions: | For each changed file, include a concise QA perspective: - - For test files (tests/**): note what the test covers and whether it is listed in - tests/integration/test_lists/test-db/ (CI) or tests/integration/test_lists/qa/ (manual QA). + - For test-code files (tests/** excluding tests/integration/test_lists/**): note what + the test covers and whether it is listed in tests/integration/test_lists/test-db/ (CI) + or tests/integration/test_lists/qa/ (manual QA). - For source files: note any observable behavior changes a QA engineer should verify (new code paths, changed APIs, altered defaults, removed functionality). Keep each entry to 1-2 sentences; omit if no QA-relevant impact. From 625037290ee29baf3cc45eedf12dc0c9fb3ea187 Mon Sep 17 00:00:00 2001 From: "Xin He (SW-GPU)" <200704525+xinhe-nv@users.noreply.github.com> Date: Fri, 24 Jul 2026 15:35:18 +0800 Subject: [PATCH 4/5] update coderabbit prompt Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com> --- .coderabbit.yaml | 39 ++++++++++++++------------------------- 1 file changed, 14 insertions(+), 25 deletions(-) diff --git a/.coderabbit.yaml b/.coderabbit.yaml index 2314dddd8ff4..a3f5ff5063cd 100644 --- a/.coderabbit.yaml +++ b/.coderabbit.yaml @@ -29,14 +29,20 @@ reviews: Correctness, performance, API consistency (CODING_GUIDELINES.md), error handling, regressions. **QA Engineer Review** - Assess whether the changed code is covered by tests outside this PR - (existing entries in tests/integration/test_lists/test-db/ for CI or - tests/integration/test_lists/qa/ for manual QA). - If no test files are modified, write "No test changes." - When CBTS artifacts are available, the verdict must cite their results: - "sufficient" only when the relevant coverage passes; otherwise "insufficient" - with the failing or missing evidence identified. - When CBTS artifacts are unavailable, use "needs follow-up". + If no test files are touched, write "No test changes." + + For test-list-only changes (only tests/integration/test_lists/ files): + - Report which test-db/ or qa/ files were modified and what entries were added or removed. + - When CBTS artifacts are available: verdict is "sufficient" if coverage passes, + "insufficient" with the failing or missing evidence identified otherwise. + - When CBTS artifacts are unavailable: verdict is "needs follow-up". + + For test-code changes (tests/** excluding tests/integration/test_lists/): + - List test functions added, modified, or removed. + - State whether each is covered in test-db/ (CI) or qa/ (manual QA). + - Apply the same CBTS-aware verdict logic above. + + Keep feedback actionable: reference concrete list file names when suggesting additions. walkthrough_instructions: | For each changed file, include a concise QA perspective: - For test-code files (tests/** excluding tests/integration/test_lists/**): note what @@ -58,23 +64,6 @@ reviews: drafts: false base_branches: ["main", "release/.+"] path_instructions: - - path: "tests/**" - instructions: | - Act as a QA engineer reviewing test changes and coverage for TensorRT-LLM. - Always produce a test coverage summary, even if no issues are found. - - If the change touches ONLY files under tests/integration/test_lists/ (no test-code changes): - - Report which test-db/ or qa/ list files were modified and what entries were added or removed. - - Do NOT require changed test functions for this path. - - Use verdict "needs follow-up" when cbts_touchmap.sqlite or a CBTS coverage report is unavailable - to confirm the impacted test scope; otherwise use "sufficient" or "insufficient". - - If the change includes test-code files (outside tests/integration/test_lists/), the summary must include: - 1. Which test functions were added, modified, or removed. - 2. Whether each changed test is listed in the appropriate test list files under - tests/integration/test_lists/ (test-db/ for CI, qa/ for manual QA). - 3. A coverage verdict: sufficient, insufficient, or needs follow-up. - Keep feedback actionable: reference concrete list file names when suggesting additions. - path: "tests/integration/test_lists/qa/**" instructions: | Files here are manually-triggered QA perf/regression lists, maintained From 4f3247ed48260226d11f750381d73c84aee2cf2c Mon Sep 17 00:00:00 2001 From: "Xin He (SW-GPU)" <200704525+xinhe-nv@users.noreply.github.com> Date: Fri, 24 Jul 2026 15:55:39 +0800 Subject: [PATCH 5/5] update coderabbit prompt Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com> --- .coderabbit.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.coderabbit.yaml b/.coderabbit.yaml index a3f5ff5063cd..47b057647353 100644 --- a/.coderabbit.yaml +++ b/.coderabbit.yaml @@ -50,6 +50,8 @@ reviews: or tests/integration/test_lists/qa/ (manual QA). - For source files: note any observable behavior changes a QA engineer should verify (new code paths, changed APIs, altered defaults, removed functionality). + - For configuration files (e.g. .coderabbit.yaml, *.yml, *.yaml, *.json, *.toml): + note any review or workflow behavior changes introduced by the config update. Keep each entry to 1-2 sentences; omit if no QA-relevant impact. collapse_walkthrough: false assess_linked_issues: true