Skip to content

[TRTLLM-12352][feat] complete MX post-transform qualification foundation#16458

Draft
chienchunhung wants to merge 2 commits into
NVIDIA:mainfrom
chienchunhung:codex/mx-foundation-completion
Draft

[TRTLLM-12352][feat] complete MX post-transform qualification foundation#16458
chienchunhung wants to merge 2 commits into
NVIDIA:mainfrom
chienchunhung:codex/mx-foundation-completion

Conversation

@chienchunhung

@chienchunhung chienchunhung commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Summary

Complete the post-transform qualification foundation needed before adding MX support for another model family.

This PR keeps LlamaForCausalLM as the only enabled profile. It replaces broad capability assumptions with an exact, test-backed contract for deciding whether a producer may publish and a receiver may consume post-transform weights.

Dependencies

The PR targets main, so its visible diff still includes #16159 while that dependency remains open. It should remain draft and be rebased after #16159 merges.

Changes

Foundation A: exact capability profiles

  • Match the exact root model class, architecture, model type, transfer scope, protocol, speculative mode, and feature constraints.
  • Capture architecture and model type from the resolved config before model construction can normalize them.
  • Resolve qualification once per load and use the same decision for SourceIdentity, publication, reception, and staged finalization.
  • Validate the public support table against the runtime registry so stale or missing profile rows fail tests.

Foundation B: reusable qualification harness

  • Parameterize full-load versus staged-load lifecycle equivalence.
  • Compare parameter and buffer names, shapes, dtypes, layouts, strides, storage offsets, and exact values.
  • Verify aliases, transform guards, derived state, and deterministic output probes.
  • Require an unregistered exact-root negative control.
  • Preserve explicit no-disk staged-receiver and unqualified disk-fallback coverage.

Foundation C: transform-layout ABI

  • Define the initial Llama ABI as trtllm-llama-target-layout-v1.
  • Bind the ABI into SourceIdentity format version 3 and MX source metadata.
  • Reject old identities and missing or mismatched ABI metadata before P2P transfer.
  • Keep format and ABI compatibility mandatory even under the ENFORCE identity policy.
  • Document ABI bump rules and the exact currently supported profile.

Scope

  • No new model family is enabled.
  • Separately loaded draft models remain unsupported for post-transform transfer.
  • Real donor/receiver GPU qualification remains required before making a readiness claim.

Validation

  • Rebase range-diff: the two Foundation commits were preserved; the only conflict combined [None][feat] Bind SourceIdentity to checkpoint artifacts #16159's newer fallback fixture with the ABI assertion.
  • Iterative self-review: no actionable findings after the rebase.
  • Changed-file pre-commit hooks: passed.
  • Python syntax compilation for all changed Python files: passed.
  • git diff --check: passed.
  • DCO signatures: preserved and passing on GitHub.
  • Focused pytest collection is unavailable locally because this checkout has no TRT-LLM runtime environment (torch and transformers are not installed); full CI is required.

@chienchunhung
chienchunhung force-pushed the codex/mx-foundation-completion branch from d7a335d to 63503c8 Compare July 22, 2026 00:44
@chienchunhung

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #60831 [ run ] triggered by Bot. Commit: 63503c8 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #60831 [ run ] completed with state SUCCESS. Commit: 63503c8
/LLM/main/L0_MergeRequest_PR pipeline #49107 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@chienchunhung

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast --stage-list "A100X-PyTorch-1,B300-PyTorch-1,DGX_B200-PyTorch-5,DGX_H100-PyTorch-5"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #61117 [ run ] triggered by Bot. Commit: 63503c8 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #61117 [ run ] completed with state SUCCESS. Commit: 63503c8
/LLM/main/L0_MergeRequest_PR pipeline #49371 (Partly Tested) completed with status: 'SUCCESS'

CI Report

Link to invocation

@chienchunhung

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #61352 [ run ] triggered by Bot. Commit: 63503c8 Link to invocation

Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
@chienchunhung
chienchunhung force-pushed the codex/mx-foundation-completion branch from 63503c8 to c0c0de5 Compare July 23, 2026 17:47

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

1 similar comment

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #61352 [ run ] completed with state SUCCESS. Commit: 63503c8
/LLM/main/L0_MergeRequest_PR pipeline #49580 completed with status: 'SUCCESS'

CI Report

Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #61354 [ run ] triggered by Bot. Commit: c0c0de5 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #61354 [ run ] completed with state FAILURE. Commit: c0c0de5
/LLM/main/L0_MergeRequest_PR pipeline #49582 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants