[https://nvbugs/6003113][fix] BREAKING CHANGE: Authenticate disagg request to verify encoded_opaque_state and ctx_info_endpoint#16002
Conversation
|
/bot help |
GitHub Bot Help
Provide a user friendly way for developers to interact with a Jenkins server. Run See details below for each supported subcommand. Details
Launch build/test pipelines. All previously running jobs will be killed.
kill
Kill all running builds associated with pull request. skip
Skip testing for latest commit on pull request. reuse-pipeline
Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break. |
|
/bot run --add-multi-gpu-test |
|
PR_Github #57826 [ run ] triggered by Bot. Commit: |
|
/bot kill |
|
PR_Github #57827 [ kill ] triggered by Bot. Commit: |
|
PR_Github/16002-0b43581 #57826 was force-killed by a newer pipeline run. |
|
PR_Github #57827 [ kill ] completed with state |
02c64ed to
fba77db
Compare
|
/bot run --add-multi-gpu-test --disable-fail-fast |
|
PR_Github #57925 [ run ] triggered by Bot. Commit: |
|
PR_Github #57925 [ run ] completed with state
|
|
/bot run --add-multi-gpu-test --disable-fail-fast |
|
PR_Github #58065 [ run ] triggered by Bot. Commit: |
|
PR_Github #58065 [ run ] completed with state
|
8db5aa4 to
a8e84e0
Compare
|
/bot run --add-multi-gpu-test --disable-fail-fast |
|
PR_Github #58297 [ run ] triggered by Bot. Commit: |
|
PR_Github #58297 [ run ] completed with state
|
375aa31 to
6557be6
Compare
|
/bot run --add-multi-gpu-test --disable-fail-fast |
|
PR_Github #58518 [ run ] triggered by Bot. Commit: |
|
PR_Github #58518 [ run ] completed with state
|
Signed-off-by: Yibin Li <109242046+yibinl-nvidia@users.noreply.github.com>
Signed-off-by: Yibin Li <109242046+yibinl-nvidia@users.noreply.github.com>
Signed-off-by: Yibin Li <109242046+yibinl-nvidia@users.noreply.github.com>
Signed-off-by: Yibin-Li <109242046+yibinl-nvidia@users.noreply.github.com>
Signed-off-by: Yibin-Li <109242046+yibinl-nvidia@users.noreply.github.com>
Signed-off-by: Yibin-Li <109242046+yibinl-nvidia@users.noreply.github.com>
Signed-off-by: Yibin-Li <109242046+yibinl-nvidia@users.noreply.github.com>
Signed-off-by: Yibin-Li <109242046+yibinl-nvidia@users.noreply.github.com>
Signed-off-by: Yibin-Li <109242046+yibinl-nvidia@users.noreply.github.com>
|
PR_Github #61385 [ run ] completed with state
|
f5b5ba9 to
b3be300
Compare
|
/bot run |
|
PR_Github #61413 [ run ] triggered by Bot. Commit: |
|
PR_Github #61413 [ run ] completed with state
|
|
/bot run |
|
PR_Github #61420 [ run ] triggered by Bot. Commit: |
|
PR_Github #61420 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #61425 [ run ] triggered by Bot. Commit: |
|
PR_Github #61425 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
1 similar comment
|
/bot run --disable-fail-fast |
|
PR_Github #61483 [ run ] triggered by Bot. Commit: |
|
PR_Github #61483 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #61538 [ run ] triggered by Bot. Commit: |
Shixiaowei02
left a comment
There was a problem hiding this comment.
Thanks for the effort. My biggest concern is the rollout design: because enforcement keys off field presence and both sides hard-fail when the key is unset, existing ctx-first deployments break at request time on upgrade. Could we add an explicit disabled/warn/enforce policy, default to warn initially, and validate key consistency at startup? Thanks!
|
PR_Github #61538 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #61569 [ run ] triggered by Bot. Commit: |
Summary
This change protects disaggregated serving’s internal proxy-to-worker handoff by requiring an internal authentication signature on requests that carry trusted handoff fields
ctx_info_endpointandencoded_opaque_state. The goal is to prevent external clients from directly injecting those internal fields while preserving normal proxy-generated disaggregated requests. This PR fixes 6003113 opaque-state and 6030763 ctx_info_endpoint protections behind one internal disaggregated HMAC auth path.Validation
Summary by CodeRabbit
New Features
Documentation
Tests