Skip to content

Fix for sporadically failing test in DALI Pipeline Framework#37

Merged
xupinjie merged 1 commit into
NVIDIA:mainfrom
RmSchaffert:dali_bbox_transform_test_fix
Jun 26, 2026
Merged

Fix for sporadically failing test in DALI Pipeline Framework#37
xupinjie merged 1 commit into
NVIDIA:mainfrom
RmSchaffert:dali_bbox_transform_test_fix

Conversation

@RmSchaffert

@RmSchaffert RmSchaffert commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

Description

  • Test was sporadically failing due to tight error bounds for results of OPs involving matmuls & inverses
  • Sporadically likely due to use of Numba with different CPUs
  • Changes
    • Removed redundant check which introduced a longer computation chain (more error accumulation)
    • Slightly increased the tolerance for other related checks

Type of Change

Please select (at least one):

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation / examples / tutorials / demos
  • Supporting functionality change (fix or feature in documentation generation, helper scripts, ...)
  • Refactoring / internal change
  • Other (please describe):

Testing

Checklist for testing:

  • Tests added or updated if/as needed
  • Repository test runner executed: scripts/run_tests.sh

Optionally, add a brief description.

Documentation, Examples, Tutorials, Demos

Checklist for documentation:

  • User-facing documentation updated if/as needed (including API docs)
  • Examples / tutorials / demos updated or added (if relevant)
  • Limitations and constraints documented (if relevant)
  • Performance documented (if relevant)
  • Documentation building successful & checks outlined in the Documentation Checks section of the Contribution Guide are performed

Optionally, add a brief description.

Code Quality

Checklist for dependencies:

  • Dependencies updated in the relevant pyproject.toml if/as needed
  • Code formatted according to the Code Formatting Guide

Optionally, add a brief description.

Related Issues / Context

If applicable, link related issues, discussions etc.


DCO / Sign-Off

Please refer to the section on Signing Your Work & Developer Certificate of Origin (DCO)
in the Contribution Guide before submitting your contribution.

References

For additional details, please refer to the Contribution Guide.
The following guides are available (referenced in the Contribution Guide for further details):

Please also refer to the summary checklist in the Contribution Guide,
which is a guideline for what to consider when submitting your contribution and covers the same topics as the checklists above.

- Test was sporadically failing due to tight error bounds for results of OPs involving matmuls & inverses
- Sporadically likely due to use of Numba with different CPUs
- Changes
  - Removed redundant check which introduced a longer computation chain (more error accumulation)
  - Slightly increased the tolerance for other related checks

Signed-off-by: Roman Schaffert <rschaffert@nvidia.com>
@RmSchaffert

Copy link
Copy Markdown
Collaborator Author

/build

1 similar comment
@RmSchaffert

Copy link
Copy Markdown
Collaborator Author

/build

@RmSchaffert RmSchaffert marked this pull request as ready for review June 24, 2026 05:55
@RmSchaffert RmSchaffert requested a review from xupinjie June 24, 2026 05:55
@xupinjie xupinjie merged commit 6d743ac into NVIDIA:main Jun 26, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants