Clamp negative SDE sampler tmp#15843
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clamp the SDE sampler's intermediate
tmpterm beforesqrt()so tiny negative drift cannot turn the update into NaNs.Root cause
In the SDE branch, the sampler computes
tmp = 1 - sigma_t**2 / (sigma_prev**2 + eps)and passes it directly tosqrt(). The shipped schedules stay non-negative in the normal path, but any slight monotonicity drift from finite precision or edge-case overrides can pushtmpjust below zero and poison the sample with NaNs.What changed
tmpwithclamp_min(0)before using it in the SDE updatetmpImpact
The SDE sampler is more numerically robust around boundary steps and invalid-nearby schedules, without changing the normal monotonic cases.
Validation
uv run pytest tests/collections/audio/test_audio_parts_submodules_schroedinger_bridge.py -k "clamps_negative_tmp_before_sqrt" -vuv run pytest tests/collections/audio/test_audio_parts_submodules_schroedinger_bridge.py -vuv run --with black==24.10.0 black --check nemo/collections/audio/parts/submodules/schroedinger_bridge.py tests/collections/audio/test_audio_parts_submodules_schroedinger_bridge.pyuv run isort --check-only nemo/collections/audio/parts/submodules/schroedinger_bridge.py tests/collections/audio/test_audio_parts_submodules_schroedinger_bridge.py