Skip to content

p2p.csv expected values cannot be reproduced by any version of the C++ reference #25

@gitmodimo

Description

@gitmodimo

The expected A__db values in p2p.csv cannot be reproduced by the C++ reference implementation at any tagged release (v1.3, v1.4) or
at HEAD. 4 of 5 test cases show discrepancies ranging from 0.09 dB to 30.34 dB.

Reproduction

A standalone validator (validate_p2p.cpp) links directly
against the reference C++ source, reads p2p.csv and pfls.csv, and calls ITM_P2P_TLS_Ex for each case.

# g++
g++ -std=c++17 -O2 -Iinclude -o validate_p2p validate_p2p.cpp src/*.cpp
./validate_p2p

# MSVC
cl /EHsc /O2 /std:c++17 /Iinclude validate_p2p.cpp src\*.cpp
validate_p2p.exe

Tested at v1.3, v1.4, and HEAD (183ad95) — all three produce identical A__db values.

Results

Case 1: C++ = 207.6450 dB, expected = 207.65 dB, diff = -0.005 dB
Case 2: C++ = 158.4071 dB, expected = 157.10 dB, diff = +1.307 dB  ***
Case 3: C++ = 178.6208 dB, expected = 178.53 dB, diff = +0.091 dB
Case 4: C++ = 191.2834 dB, expected = 183.26 dB, diff = +8.023 dB  ***
Case 5: C++ = 188.5733 dB, expected = 218.91 dB, diff = -30.337 dB ***

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions