Quarterly review of tests - 2025-10

[github-actions]

📦 Quarterly review of tests

• Schedule a Code Club to go over tests
• Review the {testdown} reports and check time that it takes to run the tests
• Review the GitHub actions to determine if any tests are notorious for being buggy
• Review the code coverage reports to identify missing tests and ensure code coverage is >= 80%
• Identify bottlenecks or challenges encountered during local test runs
• Update the minimum version of dependencies and ensure that the tests still pass
• Update devcontainer.json to include the required dependencies for developers
• Update the test README.md (WIP in PR refactor(tests): update integration test setup #990)
• Review the ability to perform the tests as a new developer
• Triage open issues related to testing
• Discuss the need for future tests and make an issue that lays out the plan

Notes

call-r-cmd-check workflows are taking longer to complete, increasing from 14 - 35 mins (2e9ddd4) to 22 - 49 mins (b86e9c6), depending on the operating system.

• The three longest-running tests that may need optimization are:

• tests/testthat/test-integration-fims-estimation-random-effects-without-wrappers.R (> 19 min)

• tests/testthat/test-integration-caa-mle-wrappers.R (> 6 min)

• tests/testthat/test-integration-caa-mle.R (> 8 min)

Using Config/testthat/start-first: file_a, file_b to prioritize certain integration tests doesn’t appear to reduce overall runtime.

• test-parallel-caa-mle-wrappers.R is outdated and needs to be updated to use the latest wrapper function.

Generated automatically by quarterly-review-of-tests.yml

[Bai-Li-NOAA]

@awilnoaa It’s great to see that you’ve completed a couple of FIMS issues through a full cycle! Do you have any feedback on the two items below? Anything that felt unclear or could be improved?

• Testing cheat sheet
• Perform the tests as a new developer

[kellijohnson-NOAA]

@Bai-Li-NOAA should we priortize getting some of these checkboxes marked off at the Code Club next Wednesday?

[Bai-Li-NOAA]

@kellijohnson-NOAA I think the following tasks could be tackled during the code club. Feel free to pick or prioritize them:

• Update the minimum versions of dependencies and ensure all tests still pass.
• Update devcontainer.json to include any required dependencies for developers.
• Triage open issues related to testing. For example, the test order issue should be a relatively low-hanging fruit.
• Update test-parallel-caa-mle-wrappers.R, which is currently outdated, to use the latest wrapper functions.

I also encountered some issues with installing FIMS on Linux and rendering the vignette. I’ll post the details later today in case they can be addressed during the code club.

[kellijohnson-NOAA]

Closing in favor of opening a new one with more up-to-date information.