From 53c6287308b2f68cbe434e9b53001c107adeb65b Mon Sep 17 00:00:00 2001 From: rmca14 <10053959+rmca14@users.noreply.github.com> Date: Fri, 31 Jul 2026 11:31:48 -0700 Subject: [PATCH] Remove approval functionality --- .../workflows/MSecD-RequireWriterReview.yml | 57 ------------------- authorized-approvers.txt | 22 ------- 2 files changed, 79 deletions(-) delete mode 100644 .github/workflows/MSecD-RequireWriterReview.yml delete mode 100644 authorized-approvers.txt diff --git a/.github/workflows/MSecD-RequireWriterReview.yml b/.github/workflows/MSecD-RequireWriterReview.yml deleted file mode 100644 index 54c371fb..00000000 --- a/.github/workflows/MSecD-RequireWriterReview.yml +++ /dev/null @@ -1,57 +0,0 @@ -name: Approver Review - -permissions: - pull-requests: write - contents: read - statuses: write - -on: - pull_request_target: - types: [opened, synchronize, reopened, labeled] - issue_comment: - types: - - created - - edited - -concurrency: - # Separate groups per event type so that issue_comment runs do not cancel - # pull_request_target runs (and vice versa). The required check_run is only - # produced by pull_request_target runs, so cross-event cancellation can leave - # the required check stuck at "cancelled" even though policy ran successfully. - group: require-writer-review-${{ github.event.pull_request.number || github.event.issue.number }}-${{ github.event_name }} - # Only cancel high-frequency issue_comment runs. pull_request_target events - # queue (at most 1 running + 1 pending per group), so supersession does not - # produce a misleading red "cancelled" check on the PR's visible head SHA. - cancel-in-progress: ${{ github.event_name == 'issue_comment' }} - -jobs: - policy: - # Job-skip policy — the two trigger families are treated differently: - # - # pull_request_target events MUST never be skipped at the job level. They - # are the only events that publish the required check on the PR head SHA. - # A skipped reusable-workflow caller job surfaces as "Approver Review / - # policy", whereas a job that runs surfaces "Approver Review / policy / - # gate" — skipping some PR events would produce two different required-check - # names. The gate derives label qualification from live PR state (not the - # event payload), so running on non-qualifying PR events is an idempotent - # no-op and keeps a single check name. - # - # issue_comment events fire for EVERY comment on EVERY issue/PR in the repo - # (and again on every edit). The vast majority are not PRMerger commands, - # and the gate's own confirmation/hold-off comments would otherwise re- - # trigger it in a feedback loop. These runs never publish the required - # head-SHA check, so filtering them out is safe for branch protection. Only - # start an issue_comment run when a human posts a '#'-command on a PR. - if: >- - (github.repository_owner == 'MicrosoftDocs' || github.repository_owner == 'microsoftgraph') - && ( - github.event_name != 'issue_comment' - || ( - github.event.issue.pull_request != null - && startsWith(github.event.comment.body, '#') - && github.event.comment.user.type != 'Bot' - ) - ) - uses: MicrosoftDocs/defender-docs/.github/workflows/MSecD-Shared-RequireWriterReview.yml@workflows-test - secrets: inherit diff --git a/authorized-approvers.txt b/authorized-approvers.txt deleted file mode 100644 index a3b67865..00000000 --- a/authorized-approvers.txt +++ /dev/null @@ -1,22 +0,0 @@ -# Authorized Approvers -# Format: CODEOWNERS syntax — last matching rule wins per file. -# Teams are resolved to individual members at runtime. -# -# Usage: -# @user1 @org/team @user2 -# -# Rules: -# - The * catch-all should be first as the default/fallback. -# - Later rules override earlier ones for matching files. -# - To keep default owners on a specific folder, include them on that line too. - -# Default owners for everything unless a later match takes precedence -* @MicrosoftDocs/msecd-org @MicrosoftDocs/identity-sdk-cca-engineering-team - -# Specific folder overrides (include default team to retain their approval) -# /FOLDER/ @MicrosoftDocs/msecd-org OPTIONAL_APPROVERS - -# API documentation does not have code owners, but that is OK. -# Anyone can create a PR to the `main` branch and we will review -# the changes on the one-off basis. -python/ \ No newline at end of file