Change onPlayBackPaused to OnPlayBackResumed

[Sarke]

It makes more sense for the playback to jumpback when the video is resumed instead of paused.

1. Sometimes you want to pause on a specific image, and jumpback changes that. When I pause it should stay on that image.
2. Sometimes when it jumps back the image goes black (not sure if hardware or codec related) and only comes back when the image is resumed.

Thanks!

[Memphiz]

Discuss this with him

#9

[Sarke]

Well it was working fine before, now it has two unintended side effects.
I think a workaround like his should not introduce issues for everyone else.
Perhaps an option to jump back on pause instead of resume could work, but it should not be the default.
On Sun, Nov 30, 2014 at 1:53 AM, Memphiz notifications@github.com wrote:Discuss this with him

#9

—Reply to this email directly or view it on GitHub.

[Memphiz]

please rollback to the previous version then for the time beeing - no time to work on it for a while as we are in rc phase for helix - maybe you could really talk it out with @anaconda so its not on me...

@Sarke is that Gotham (v13)?

Of course I get the same behavior as before, otherwise I wouldn't have PR'ed it upstream, but I'm testing on Helix (v14, currently in beta). Works fine on a Raspberry Pi and I have just tested again on OS X.

Specifically, on Helix: 1) is still true - even if rewinded (and cached) while still paused, the picture is still the same until playback is actually resumed; 2) seems to depend on 1) and I can't reproduce.

I suggest you revert #9 if issues are reported, making it an option excessively complicates a simple script.

[vertigo220]

@anaconda

If making it an option would make the script too complicated, why not fork it into a separate addon? It makes no sense to have an addon called UNpause Jumpack that jumps back on pause. It just leads to confusion and frustration when it doesn't work as the name and description imply. I understand the logic behind the change, but for many, myself included, that logic doesn't apply, and we'd rather have it work the way it used to, they way its name suggests. It makes much more sense to make it an option or, if that's not ideal, then make a separate addon called Pause Jumpback that rewinds on pause and make Unpause Jumpback rewind on unpause.