Question: Is the `event` and `eventview` separation fine now?

[Olf0]

I wondered, if the separation (i.e. the conditional building) of the event and eventview sub-packages is working fine?
I.e., if the build conditions ([1], [2]) for these two sub-packages create appropriate results for the two build environments currently used: Coderus' Sailfish-SDK Docker-images for the CI/CD-workflow at GitHub and the SailfishOS-OBS. Side note: I expect that building locally with the Sailfish-SDK installed natively provides the same build environment as Coderus' Sailfish-SDK Docker-images.

I am positively surprised that my first take on this seem to work perfectly, which is better than expected, because I never took a look at the build environment (specifically the macros set) inside the Sailfish-SDK.
When looking at the results of a recent CI/CD run, I see that both event and eventview sub-packages are built, which indicates that the RPM-macro sailfishos_version is not defined inside the Sailfish-SDK.

Thus it appears to be sufficient to use the existence of the RPM-macro sailfishos_version as a differentiator for building either at the SailfishOS-OBS or elsewhere (which is the status quo).

Side note: I opened issue #68, because this is currently not utilised as intended. I will leave this issue open until issue #68 is resolved, so we can properly discuss general aspects (here, i.e. #67) and OpenRepos-specific aspects (in #68) separately.

---

For documentation only

Meanwhile I considered which other macros could be used as such differentiators and remembered that I already performed this research a while ago in a different context: sailfishos-chum/sailfishos-chum-gui#149 (comment)

• The RPM-macros %_project and %_repository are specifically set by OBS (i.e. should not be defined when building elsewhere).
  Side note: Jolla sets them again in their DoD-repo configs as RPM-macros (while un-setting does not work in my experience, overwriting / redefining does) and additionally as %defines (ugh, "overwrite" a RPM-macro by a spec file local %define; I wonder if the behaviour for this is specified).
• The RPM-macro %_chum is only set for the SailishOS-OBS repositories SailfishOS:Chum and SailfishOS:Chum:Testing (or OBS-repos trying to mimic these).

If ever needed, these could alternatively used as differentiators for building either at the SailfishOS-OBS or not.

[Thaodan]

There should be no need to handle packaging differently locally vs. on the obs. If so it's usually a sign of bad packaging of the app or bad packaging of its dependencies for various reason which are not always (but sometimes) the apps fault.

[Olf0]

@Thaodan, your comment is neither constructive or helpful, as usual. Yes, this is more complicated than it should due to the long history of MeeCast and the fact that it targets multiple Linux distributions. If you have an specific solution in mind how to ease this without breaking anything for MeeCast's various targets, please pose a PR.

[Thaodan]

Don't really know what to say beyond that I don't think it's helpful to personally attack me here. I was arguing that the current solution is good and that sometimes you can't get a perfect solutions, without major rework, as cleaning the legacy debt that causes these workarounds in the first place is hard work. To package the package in the same way on the obs or in the sdk all the dependencies have to be package so they can be pulled in as BuildRequires rather then as a script that requires an internet connection. I was surprised how good the packaging of meecast actually was since some of the packages have packaging that does mistakes such as copying shared libraries from packages or requiring shared libraies explicitly instead RPM adding dependencies to these on its own. The absence of the Sailfish-version can be remedied by parsing the version from /etc/os-release using the shell function like `%define %()' So the full rpm macro should look like this: %if %{undefined sailfish_version} %define sailfish_version %(sed -n -e '/^VERSION_ID/ s/VERSION_ID=\(.*\)\.\(.*\)\.\(.*\)\.\(.*\)/\1\2\3\4/ p' -e 's/\.//'/etc/os-release)" %endif You can test the command by running: rpm --eval "%(sed -n -e '/^VERSION_ID/ s/VERSION_ID=\(.*\)\.\(.*\)\.\(.*\)\.\(.*\)/\1\2\3\4/ p' -e 's/\.//'/etc/os-release)" The sed command matches a line that starts with 'VERSION_ID' and then extracts the numbers between the dots after VERSION_ID=.