Replies: 26 comments 14 replies
-
Beta Was this translation helpful? Give feedback.
-
|
Program crashing immediately at start, obviously due to geosearch enabled before closing previous session: |
Beta Was this translation helpful? Give feedback.
-
|
yes, yes, this is known. It's a mockup not a PR ready for complete deep testing and review. So far project and GIS items are implemented by their basic information and functions. |
Beta Was this translation helpful? Give feedback.
-
|
Now tags and rating for GIS items visible again:
|
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
Project keywords & GIS item statistics:
|
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
I need some feedback on this. The tool buttons of the project items can be placed in the name or in the status line.
Placing them into the status line has the advantage that they do not collide with very long project names. On the other hand side if you have many keywords they collide with the status line. Personally I would like to have them in the same line as the name as this creates a natural border to the project above:
As I like my project names short and crisp this is not a problem for me but there will be this one user... Anyways it's a matter of personal taste. You can try it yourself. In CWksItemDelegate.cpp line 33 you can define OPTION to be 1 or 2. @mitxel-m @kkarsten62 @wthaem @JFritzle and everyone else I would appreciate your feedback. |
Beta Was this translation helpful? Give feedback.
-
|
As long as a long project name becomes fully shown in tooltip when hovering over project item, I see no problem with solution 2nd screenshot. Behavior would be comparable to long map/dem names. In my opinion, it is not a real gain in information to see number of tracks/routes/waypoints in status line, as project's tooltip already contains that information. This would allow more or longer keywords to be visible. Maybe keywords should be included in tooltip too, solving problem long keyword list not being fully visible? |
Beta Was this translation helpful? Give feedback.
-
|
My five cents:
@kiozen : Many thanks for the feature and go ahead :-) |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
What about ...
|
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
|
@mitxel-m I am always in favor of nice icons. And to make nicer ones than I do is easy. I am an engineer not an artist 😁 PR is the way to go (ticket, change log, etc)! If you want to add better icons in batches simply reuse the ticket in that case. Placing the tool buttons 😃 I already tried all the stuff you suggested. The initial one was ordering them in a 2x2 square. I don't like it because your eye could not follow columns. With several projects in a row it was a wild mosaic of buttons. That's why I switched to all buttons in a row. To make these buttons full tool button size is a problem for smaller screens where the workspace docker's size should be as small as possible. Plus this collides with the name and the status line. Placing them into the status line was my next try. Reasoning: better limit the status than the name. However this does not look nice with several projects in a row (column). The items are not really distinguished from each other by a clear UI design. That's why I placed them into the upper line of the name. In this line there is more space as the font is larger. Therefore the buttons can be a tiny bit larger, too. And probably the status line (2nd line) will get more crowded in future. The buttons have the same height and width as the font of the name. I would assume if you can read the name the buttons should be large enough to. Of course the icons have to be more simple. That why I changed them . Maybe it's a good idea to change the ones in the context menu, too. And, btw, the geo search is back: |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
Philosophical question: Should a read-only project become active project? It can serve as a bucket for new items. No question. But you will never be able to save it. Why I ask: Should the active project button be hidden just like the save button for read only projects. And just to move on with the reasoning: Same applies to auto sync to device? |
Beta Was this translation helpful? Give feedback.
-
|
I just tested my use cases with the latest commits from branch
==> All is working fine for me :-)
|
Beta Was this translation helpful? Give feedback.
-
I donated some extra pixel between items. But in general I would like to keep the condensed layout
Ooops and it's in the status line. Moved it up to the upper line. By that the size should fit the name and thus all other items. |
Beta Was this translation helpful? Give feedback.
-
|
To keep stuff a bit more consistent the geo search item is now the same size as a project
|
Beta Was this translation helpful? Give feedback.
-
|
I tested again - Funcs works as expected with the new icons - I like the new icons from @mitxel-m :-) Please have a look at
|
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
I added the mitigation code to migrate "old" workspace to new one. Other way around is not possible - as usual. |
Beta Was this translation helpful? Give feedback.
-
|
Ok, I will take a look too.
I think that #ffff00 should look well even over gray. If needed the trick is to draw the star with a 1px black border and #ffff00 fill.
This is fine tailoring :-)
2026(e)ko otsailaren 6(a) 16:54:23 (CET)-(e)an, Kiozen ***@***.***>-(e)k hau idatzi zuen:
…The project filter is already fixed. Event in it's width. I found the culprit.
The GeoSearch line edit I can make a bit larger. Will do.
The red star ⭐ 😄 I changed it because the yellow is so close to the gray of the inactive projects. The red is more visible for me. Maybe a star is a bad choice. Maybe a circle is better. I will give it a try.
--
Reply to this email directly or view it on GitHub:
#943 (reply in thread)
You are receiving this because you were mentioned.
Message ID: ***@***.***>
|
Beta Was this translation helpful? Give feedback.
-
|
I pushed another change hiding most of the buttons for projects when not selected. With all these buttons the UI gets a bit overloaded. Sure it's nice because you have all the functions by a single click. On the other hand side there are so many buttons, you hardly know where to click. Now you have to click on the project first to get all buttons. Following the design rules of the canvas: "click on an item to get information and available functions". I left the "Visibility" button as a static one. Con:
Pro:
@mitxel-m your yellow star is back! ⭐ twinkle, twinkle. Because without all this visual noise it's easy to see what project is the active one. Regardless what color the star is. So I do not mind if I can't really tell the difference between a yellow and a grey star in a button 😎
|
Beta Was this translation helpful? Give feedback.
-
|
Ok, the code is more or less ready to be merged. Last call for bugs 🐛 |
Beta Was this translation helpful? Give feedback.
-
|
After a few days away, I have managed to try out the latest changes and they work well for me. In my opinion, the latest change, where the buttons are only displayed when you select a project, is a good idea, because it makes the workspace look lighter and less cluttered. The only downside for me is that I still have trouble reading the A and S buttons on my screen because they are too small, but this is an issue with my computer that does not affect their function :-). I will try to take a look at the corresponding icons to see if I can improve anything, but there is not much margin for adjustment at this size. Next, I am going to test the PR regarding the database panel too. Thanks for all your work! |
Beta Was this translation helpful? Give feedback.




















Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Here we go! What adds more fun to a QStyledItemDelegate in the map and DEM lists? Right! Adding another one in the workspace list aka CGisListWks. This is already a huge code change just to produce a mockup!
It's again on the testing_stuff branch of my development fork (https://github.com/kiozen/qmapshack/tree/testing_stuff).
Warning! This messes up your workspace data base. Either wipe the workspace when switching between dev and this branch or make a safety copy of your workspace.db.
Despite the complete pain in the ass to convert the code to a delegate and finding a lot of crude stuff that crept in and has to get fixed before proceeding, the charm of the whole exercise is to have quite some freedom in how to design each item. And yes, yes, drag-n-drop and the whole shit is working better to.
So, what's the result? A lot of broken stuff for sure. Some bugs fixed, a lot more introduced 😁 .But we got rid of columns not fitting the view and that horizontal scrollbar 🎉 . Having more freedom to place tool buttons wherever I want I added 4! Crazy! The one with the eye is replacing the former checkbox.
The other three add functions from the context menu right into the UI. Probable most of you are not aware of these functions or simply forgot about them or ignoring them. Which is a pity as they are real cool features of QMapShack deserving a bit more attention. These are: auto save, auto sync. with GPS devices and active project. Active project is a very useful feature when planning stuff. If an active project is selected everything that usually requires the user to select a project simply use that project without asking.
Right now the items are quite large in terms of their height. This is because there will be extra information like rating and tags. And you will notice that with a delegate it's quite easy to highlight text for items in focus or to gray out stuff that's not visible. Even with it's limited functionality the mockup is already a gain in my eyes.
If you test please be selective with bug reports. Cross check if the same bug is in the dev branch -> bug ticket please. If not differentiate between missing feature and the feature behaves really buggy. The later is of interest.
Looking forward to your feedback!
Beta Was this translation helpful? Give feedback.
All reactions