Plugin that allows reset stats via chat command#780
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new feature plugin for OpenMU that enables players to reset their character stats. It includes a comprehensive configuration model to define requirements such as level, cost, and items, and provides a chat command interface for players to execute the reset. The implementation also handles post-reset actions like teleporting to a safezone or logging out to the character selection screen. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a stat reset feature, allowing players to reset their character attributes to base values and reclaim invested points via a new /resetstats chat command. The implementation includes a configurable plugin system, localized messaging, and logic for handling costs (money or items) and post-reset actions like teleportation or logout. Feedback from the review highlights the need to use standard teleportation methods to maintain client synchronization, improve safety in attribute calculations, refactor duplicated cost-checking logic, and ensure the client UI correctly reflects updated level-up points. Additionally, a hardcoded display name in the configuration should be replaced with a localized resource key.
|
Thanks :) |
Stat Reset Plugin for OpenMU
A plugin that allows players to reset their character's stats back to base values and refund all invested points.
Features
/resetstats(toggleable)Configuration
/resetstatscommandFiles
GameLogic/Resets/StatResetFeaturePlugIn.cs- Feature plugin (implementsIFeaturePlugIn)GameLogic/Resets/StatResetConfiguration.cs- Configuration modelGameLogic/Resets/ResetStatsAction.cs- Core reset logicGameLogic/Resets/ResetStatsChatCommandPlugIn.cs-/resetstatschat command handlerGameLogic/Properties/PlayerMessage.Designer.cs+.resx- Localized player messagesGameLogic/Properties/PlugInResources.Designer.cs+.resx- Localized plugin display names