From e26c7a7abafdde30e67e9c1db9bef5cd2f7a5220 Mon Sep 17 00:00:00 2001
From: LudwigBoess <lboess@usm.lmu.de>
Date: Fri, 1 May 2026 17:52:18 +0200
Subject: [PATCH 1/7] Added Gupta+24 efficiency

---
 src/mach_models/Gupta24.jl | 79 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 79 insertions(+)
 create mode 100644 src/mach_models/Gupta24.jl

diff --git a/src/mach_models/Gupta24.jl b/src/mach_models/Gupta24.jl
new file mode 100644
index 0000000..57984a4
--- /dev/null
+++ b/src/mach_models/Gupta24.jl
@@ -0,0 +1,79 @@
+"""
+    Gupta24_p(X_cr::T=1.0, η_max::T=0.03) where T
+
+Efficiency model for protons by Gupta, Caprioli & Sptikovsky (2024)
+
+## Values 
+- `X_cr`: P_cr / P_th defined in model for re-acceleration. Basis for interpolation between acceleration and re-acceleration efficiency.
+- `η_max`: Maximum efficiency defined in the model
+"""
+struct Gupta24_p{T} <: AbstractShockAccelerationEfficiency
+    X_cr::T
+    η_max::T
+
+    Gupta24_p(X_cr::T = 1.0, η_max::T = 0.1) where {T} = new{T}(X_cr, η_max)
+end
+
+"""
+    η_Ms_acc(η_model::Gupta24_p, M::Real)
+
+Initial acceleration efficiency model for protons by Gupta, Caprioli & Sptikovsky (2024)
+"""
+function η_Ms_acc(η_model::Gupta24_p, M::Real)
+    if M < 2.0
+        return 0
+    else
+        return η_model.η_max
+    end
+end
+
+"""
+    η_Ms_reacc(η_model::Gupta24_p, M::Real)
+
+Reacceleration efficiency for model by Kang (2024), identical to acceleration efficiency.
+"""
+function η_Ms_reacc(η_model::Gupta24_p, M::Real)
+    η_Ms_acc(η_model, M)
+end
+
+
+
+"""
+    Gupta24_e(X_cr::T=1.0, η_max::T=0.0004871685) where T
+
+Efficiency model for electrons by Gupta, Caprioli & Sptikovsky (2024)
+
+## Values 
+- `X_cr`: P_cr / P_th defined in model for re-acceleration. Basis for interpolation between acceleration and re-acceleration efficiency.
+- `η_max`: Maximum efficiency defined in the model
+"""
+struct Gupta24_e{T} <: AbstractShockAccelerationEfficiency
+    X_cr::T
+    η_max::T
+
+    Gupta24_e(X_cr::T = 1.0, η_max::T = 0.06) where {T} = new{T}(X_cr, η_max)
+end
+
+
+"""
+    η_Ms_acc(η_model::Gupta24_e, M::Real)
+
+Initial acceleration efficiency model for electrons by Gupta, Caprioli & Sptikovsky (2024)
+"""
+function η_Ms_acc(η_model::Gupta24_e, M::Real)
+    if M < 2.0
+        return 0
+    else
+        p = [19.301588195907662, -0.6544505664085758, 30053.623240151297, -2.420544376432326, 0.0024391157810159103]
+        return p[1] * M^p[2] / (1 + p[3] * M^p[4]) + p[5]
+    end
+end
+
+"""
+    η_Ms_reacc(η_model::Gupta24_e, M::Real)
+
+Reacceleration efficiency for model by Kang (2024), identical to acceleration efficiency.
+"""
+function η_Ms_reacc(η_model::Gupta24_e, M::Real)
+    η_Ms_acc(η_model, M)
+end

From 7ab34bc7f018faf14a8fd54a11c7da96148fdd89 Mon Sep 17 00:00:00 2001
From: LudwigBoess <lboess@usm.lmu.de>
Date: Sat, 16 May 2026 16:03:46 +0200
Subject: [PATCH 2/7] rewrite theta efficiency model for multiple dispatch

---
 src/B_models/gupta.jl                   | 51 +++++++++++++++++++++++++
 src/B_models/pais.jl                    | 33 +++++++++++-----
 src/DiffusiveShockAccelerationModels.jl | 24 +++++++++---
 3 files changed, 93 insertions(+), 15 deletions(-)
 create mode 100644 src/B_models/gupta.jl

diff --git a/src/B_models/gupta.jl b/src/B_models/gupta.jl
new file mode 100644
index 0000000..110a513
--- /dev/null
+++ b/src/B_models/gupta.jl
@@ -0,0 +1,51 @@
+"""
+    Gupta24_t(X_cr::T=0.05) where T
+
+Efficiency model by Gupta24_t, Caprioli & Spitkovsky 2024: MNRAS, 478, 4, 5278–5295, https://arxiv.org/pdf/1805.00128.pdf
+
+## Values 
+- `X_cr`: P_cr / P_th defined in model for re-acceleration. Basis for interpolation between acceleration and re-acceleration efficiency.
+"""
+struct Gupta24_t{T} <: AbstractShockAccelerationEfficiency
+    X_cr::T
+    Gupta24_t(X_cr::T = 0.05) where {T} = new{T}(X_cr)
+end
+
+"""
+    η_B(η_model::Gupta24_t, θ_B::Real, θ_crit::Real)
+
+Calculate B angle dependent efficiency component following Pais et. al. 2018, eq. 7, https://arxiv.org/pdf/1805.00128.pdf
+"""
+@inline function η_B(η_model::Gupta24_t, θ_B::Real, θ_crit::Real)
+    (tanh((θ_crit - θ_B) / π / 18) + 1) / 2
+end
+
+"""
+    ηB_acc_p(η_model::Gupta24_t, θ_B::Real)
+
+Magnetic field geometry dependent efficiency for protons at initial acceleration.
+"""
+function ηB_acc_p(η_model::Gupta24_t, θ_B::Real)
+    η_B(η_model, θ_B, π / 3.5)
+end
+
+"""
+    ηB_reacc_p(η_model::Gupta24_t, θ_B::Real)
+
+Magnetic field geometry dependent efficiency for protons at reacceleration.
+"""
+ηB_reacc_p(η_model::Gupta24_t, θ_B::Real) = ηB_acc_p(η_model, θ_B)
+
+"""
+    ηB_acc_e(η_model::Gupta24_t, θ_B::Real)
+
+Magnetic field geometry dependent efficiency for electrons at initial acceleration.
+"""
+ηB_acc_e(η_model::Gupta24_t, θ_B::Real) = ηB_acc_p(η_model, θ_B)
+
+"""
+    ηB_reacc_e(η_model::Gupta24_t, θ_B::Real)
+
+Magnetic field geometry dependent efficiency for electrons at reacceleration.
+"""
+ηB_reacc_e(η_model::Gupta24_t, θ_B::Real) = ηB_acc_p(η_model, θ_B)
\ No newline at end of file
diff --git a/src/B_models/pais.jl b/src/B_models/pais.jl
index c044b9e..29c6596 100644
--- a/src/B_models/pais.jl
+++ b/src/B_models/pais.jl
@@ -3,12 +3,27 @@ const π_third = π / 3
 const π_fourth = π / 4
 const π_sixth = π / 6
 
+
+"""
+    Pais2018_t(X_cr::T=0.05) where T
+
+Efficiency model by Pais et al. 2018: MNRAS, 478, 4, 5278–5295, https://arxiv.org/pdf/1805.00128.pdf
+
+## Values 
+- `X_cr`: P_cr / P_th defined in model for re-acceleration. Basis for interpolation between acceleration and re-acceleration efficiency.
+"""
+struct Pais2018_t{T} <: AbstractShockAccelerationEfficiency
+    X_cr::T
+    Pais2018_t(X_cr::T = 0.05) where {T} = new{T}(X_cr)
+end
+
+
 """
     η_B(θ_B::Real, θ_crit::Real)
 
 Calculate B angle dependent efficiency component following Pais et. al. 2018, eq. 7, https://arxiv.org/pdf/1805.00128.pdf
 """
-@inline function η_B(θ_B::Real, θ_crit::Real)
+@inline function η_B(η_model::Pais2018_t, θ_B::Real, θ_crit::Real)
     (tanh((θ_crit - θ_B) / δθ) + 1) / 2
 end
 
@@ -17,8 +32,8 @@ end
 
 Magnetic field geometry dependent efficiency for protons at initial acceleration.
 """
-function ηB_acc_p(θ_B::Real)
-    η_B(θ_B, π_fourth)
+function ηB_acc_p(η_model::Pais2018_t, θ_B::Real)
+    η_B(η_model, θ_B, π_fourth)
 end
 
 """
@@ -26,8 +41,8 @@ end
 
 Magnetic field geometry dependent efficiency for protons at reacceleration.
 """
-function ηB_reacc_p(θ_B::Real)
-    η_B(θ_B, π_third)
+function ηB_reacc_p(η_model::Pais2018_t, θ_B::Real)
+    η_B(η_model, θ_B, π_third)
 end
 
 """
@@ -35,8 +50,8 @@ end
 
 Magnetic field geometry dependent efficiency for electrons at initial acceleration.
 """
-function ηB_acc_e(θ_B::Real)
-    1 - η_B(θ_B, π_fourth)
+function ηB_acc_e(η_model::Pais2018_t, θ_B::Real)
+    1 - η_B(η_model, θ_B, π_fourth)
 end
 
 """
@@ -44,6 +59,6 @@ end
 
 Magnetic field geometry dependent efficiency for electrons at reacceleration.
 """
-function ηB_reacc_e(θ_B::Real)
-    1 - η_B(θ_B, π_sixth)
+function ηB_reacc_e(η_model::Pais2018_t, θ_B::Real)
+    1 - η_B(η_model, θ_B, π_sixth)
 end
\ No newline at end of file
diff --git a/src/DiffusiveShockAccelerationModels.jl b/src/DiffusiveShockAccelerationModels.jl
index ba720b0..1da8eac 100644
--- a/src/DiffusiveShockAccelerationModels.jl
+++ b/src/DiffusiveShockAccelerationModels.jl
@@ -5,6 +5,8 @@ export AbstractShockAccelerationEfficiency,
     # efficiency models
     Kang07, KR13, CS14, Ryu19, P16, 
     Kang24_p, Kang24_e,
+    Gupta24_p, Gupta24_e, 
+    Gupta24_t, Pais2018_t, 
     # mach nummber dependent efficiency 
     η_Ms, η_Ms_acc, η_Ms_reacc,
     # B-field dependent efficiency
@@ -75,22 +77,29 @@ function η_Ms(η_model::AbstractShockAccelerationEfficiency, M::T, X_cr::T) whe
 end
 
 
-
 include("mach_models/Kang07.jl")
 include("mach_models/KR13.jl")
 include("mach_models/CS14.jl")
 include("mach_models/Ryu19.jl")
 include("mach_models/Pfrommer16.jl")
 include("mach_models/Kang24.jl")
+include("mach_models/Gupta24.jl")
 
 include("B_models/pais.jl")
+include("B_models/gupta.jl")
+
+ηB_acc_p(θ_B::Real) = ηB_acc_p(Pais2018_t(), θ_B)
+ηB_acc_e(θ_B::Real) = ηB_acc_e(Pais2018_t(), θ_B)
+ηB_reacc_p(θ_B::Real) = ηB_reacc_p(Pais2018_t(), θ_B)
+ηB_reacc_e(θ_B::Real) = ηB_reacc_e(Pais2018_t(), θ_B)
 
 using PrecompileTools    # this is a small dependency
 
 @setup_workload begin
     # Putting some things in `setup` can reduce the size of the
     # precompile file and potentially make loading faster.
-    η_models = [Kang07(), KR13(), CS14(), Ryu19(), Kang24_p(), Kang24_e()]
+    η_models = [Kang07(), KR13(), CS14(), Ryu19(), Kang24_p(), Kang24_e(), Gupta24_p(), Gupta24_e()]
+    B_models = [Pais2018_t(), Gupta24()]
 
     @compile_workload begin
         # all calls in this block will be precompiled, regardless of whether
@@ -109,10 +118,13 @@ using PrecompileTools    # this is a small dependency
             end
         end
 
-        ηB_acc_p(1.0)
-        ηB_reacc_p(1.0)
-        ηB_acc_e(1.0)
-        ηB_reacc_e(1.0)
+        # loop over models
+        for η ∈ B_models
+            ηB_acc_p(η, 1.0)
+            ηB_reacc_p(η, 1.0)
+            ηB_acc_e(η, 1.0)
+            ηB_reacc_e(η, 1.0)
+        end
     end
 end
 

From 1c5a703aaef93f8e78cdbc2a2f633fa83805760f Mon Sep 17 00:00:00 2001
From: LudwigBoess <lboess@usm.lmu.de>
Date: Sat, 16 May 2026 16:04:11 +0200
Subject: [PATCH 3/7] Gupta+24 acceleration model

---
 src/B_models/gupta.jl                   | 28 ++++++++++++-------------
 src/DiffusiveShockAccelerationModels.jl |  2 +-
 src/mach_models/Gupta24.jl              |  4 ++--
 3 files changed, 17 insertions(+), 17 deletions(-)

diff --git a/src/B_models/gupta.jl b/src/B_models/gupta.jl
index 110a513..db7b525 100644
--- a/src/B_models/gupta.jl
+++ b/src/B_models/gupta.jl
@@ -1,51 +1,51 @@
 """
-    Gupta24_t(X_cr::T=0.05) where T
+    Gupta2024_t(X_cr::T=0.05) where T
 
-Efficiency model by Gupta24_t, Caprioli & Spitkovsky 2024: MNRAS, 478, 4, 5278–5295, https://arxiv.org/pdf/1805.00128.pdf
+Efficiency model by Gupta2024_t, Caprioli & Spitkovsky 2024: MNRAS, 478, 4, 5278–5295, https://arxiv.org/pdf/1805.00128.pdf
 
 ## Values 
 - `X_cr`: P_cr / P_th defined in model for re-acceleration. Basis for interpolation between acceleration and re-acceleration efficiency.
 """
-struct Gupta24_t{T} <: AbstractShockAccelerationEfficiency
+struct Gupta2024_t{T} <: AbstractShockAccelerationEfficiency
     X_cr::T
-    Gupta24_t(X_cr::T = 0.05) where {T} = new{T}(X_cr)
+    Gupta2024_t(X_cr::T = 0.05) where {T} = new{T}(X_cr)
 end
 
 """
-    η_B(η_model::Gupta24_t, θ_B::Real, θ_crit::Real)
+    η_B(η_model::Gupta2024_t, θ_B::Real, θ_crit::Real)
 
 Calculate B angle dependent efficiency component following Pais et. al. 2018, eq. 7, https://arxiv.org/pdf/1805.00128.pdf
 """
-@inline function η_B(η_model::Gupta24_t, θ_B::Real, θ_crit::Real)
+@inline function η_B(η_model::Gupta2024_t, θ_B::Real, θ_crit::Real)
     (tanh((θ_crit - θ_B) / π / 18) + 1) / 2
 end
 
 """
-    ηB_acc_p(η_model::Gupta24_t, θ_B::Real)
+    ηB_acc_p(η_model::Gupta2024_t, θ_B::Real)
 
 Magnetic field geometry dependent efficiency for protons at initial acceleration.
 """
-function ηB_acc_p(η_model::Gupta24_t, θ_B::Real)
+function ηB_acc_p(η_model::Gupta2024_t, θ_B::Real)
     η_B(η_model, θ_B, π / 3.5)
 end
 
 """
-    ηB_reacc_p(η_model::Gupta24_t, θ_B::Real)
+    ηB_reacc_p(η_model::Gupta2024_t, θ_B::Real)
 
 Magnetic field geometry dependent efficiency for protons at reacceleration.
 """
-ηB_reacc_p(η_model::Gupta24_t, θ_B::Real) = ηB_acc_p(η_model, θ_B)
+ηB_reacc_p(η_model::Gupta2024_t, θ_B::Real) = ηB_acc_p(η_model, θ_B)
 
 """
-    ηB_acc_e(η_model::Gupta24_t, θ_B::Real)
+    ηB_acc_e(η_model::Gupta2024_t, θ_B::Real)
 
 Magnetic field geometry dependent efficiency for electrons at initial acceleration.
 """
-ηB_acc_e(η_model::Gupta24_t, θ_B::Real) = ηB_acc_p(η_model, θ_B)
+ηB_acc_e(η_model::Gupta2024_t, θ_B::Real) = ηB_acc_p(η_model, θ_B)
 
 """
-    ηB_reacc_e(η_model::Gupta24_t, θ_B::Real)
+    ηB_reacc_e(η_model::Gupta2024_t, θ_B::Real)
 
 Magnetic field geometry dependent efficiency for electrons at reacceleration.
 """
-ηB_reacc_e(η_model::Gupta24_t, θ_B::Real) = ηB_acc_p(η_model, θ_B)
\ No newline at end of file
+ηB_reacc_e(η_model::Gupta2024_t, θ_B::Real) = ηB_acc_p(η_model, θ_B)
\ No newline at end of file
diff --git a/src/DiffusiveShockAccelerationModels.jl b/src/DiffusiveShockAccelerationModels.jl
index 1da8eac..a31b334 100644
--- a/src/DiffusiveShockAccelerationModels.jl
+++ b/src/DiffusiveShockAccelerationModels.jl
@@ -99,7 +99,7 @@ using PrecompileTools    # this is a small dependency
     # Putting some things in `setup` can reduce the size of the
     # precompile file and potentially make loading faster.
     η_models = [Kang07(), KR13(), CS14(), Ryu19(), Kang24_p(), Kang24_e(), Gupta24_p(), Gupta24_e()]
-    B_models = [Pais2018_t(), Gupta24()]
+    B_models = [Pais2018_t(), Gupta2024_t()]
 
     @compile_workload begin
         # all calls in this block will be precompiled, regardless of whether
diff --git a/src/mach_models/Gupta24.jl b/src/mach_models/Gupta24.jl
index 57984a4..91344e4 100644
--- a/src/mach_models/Gupta24.jl
+++ b/src/mach_models/Gupta24.jl
@@ -51,7 +51,7 @@ struct Gupta24_e{T} <: AbstractShockAccelerationEfficiency
     X_cr::T
     η_max::T
 
-    Gupta24_e(X_cr::T = 1.0, η_max::T = 0.06) where {T} = new{T}(X_cr, η_max)
+    Gupta24_e(X_cr::T = 1.0, η_max::T = 0.05) where {T} = new{T}(X_cr, η_max)
 end
 
 
@@ -65,7 +65,7 @@ function η_Ms_acc(η_model::Gupta24_e, M::Real)
         return 0
     else
         p = [19.301588195907662, -0.6544505664085758, 30053.623240151297, -2.420544376432326, 0.0024391157810159103]
-        return p[1] * M^p[2] / (1 + p[3] * M^p[4]) + p[5]
+        return (p[1] * M^p[2] / (1 + p[3] * M^p[4]) + p[5]) * 0.25
     end
 end
 

From 65476b3b64a67a40bda9f32e6d597d4bf74c7b03 Mon Sep 17 00:00:00 2001
From: LudwigBoess <lboess@usm.lmu.de>
Date: Sat, 16 May 2026 16:04:22 +0200
Subject: [PATCH 4/7] updated version number

---
 Project.toml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Project.toml b/Project.toml
index c9577fb..a401b74 100644
--- a/Project.toml
+++ b/Project.toml
@@ -1,7 +1,7 @@
 name = "DiffusiveShockAccelerationModels"
 uuid = "66fc4661-a670-4cc2-b407-bfd81989e880"
 authors = ["Ludwig Böss"]
-version = "0.1.2"
+version = "0.2.0"
 
 [deps]
 PrecompileTools = "aea7be01-6a6a-4083-8856-8a6e6704d82a"

From ec70a766a6dd7fe15dbb3ec63f5015c23030db2e Mon Sep 17 00:00:00 2001
From: LudwigBoess <lboess@usm.lmu.de>
Date: Thu, 16 Jul 2026 18:09:33 +0200
Subject: [PATCH 5/7] bugfix in export

---
 src/DiffusiveShockAccelerationModels.jl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/DiffusiveShockAccelerationModels.jl b/src/DiffusiveShockAccelerationModels.jl
index a31b334..c9eeddb 100644
--- a/src/DiffusiveShockAccelerationModels.jl
+++ b/src/DiffusiveShockAccelerationModels.jl
@@ -6,7 +6,7 @@ export AbstractShockAccelerationEfficiency,
     Kang07, KR13, CS14, Ryu19, P16, 
     Kang24_p, Kang24_e,
     Gupta24_p, Gupta24_e, 
-    Gupta24_t, Pais2018_t, 
+    Gupta2024_t, Pais2018_t, 
     # mach nummber dependent efficiency 
     η_Ms, η_Ms_acc, η_Ms_reacc,
     # B-field dependent efficiency

From 4a23c78fcde4b1f4b1a785000bcafb6009e2ae62 Mon Sep 17 00:00:00 2001
From: LudwigBoess <lboess@usm.lmu.de>
Date: Thu, 16 Jul 2026 18:20:56 +0200
Subject: [PATCH 6/7] updated docs

---
 docs/src/index.md                       | 26 ++++++++++++----
 src/DiffusiveShockAccelerationModels.jl |  4 +--
 src/mach_models/Gupta24.jl              | 40 -------------------------
 3 files changed, 22 insertions(+), 48 deletions(-)

diff --git a/docs/src/index.md b/docs/src/index.md
index e1345e4..f7070e3 100644
--- a/docs/src/index.md
+++ b/docs/src/index.md
@@ -54,6 +54,13 @@ Kang24_e
 ![Kang 2024 DSA model](Kang2024.png)
 
 
+Version `v0.2` included the model by [Gupta et al. (2025)](https://arxiv.org/pdf/1805.00128.pdf)
+
+```@docs
+Gupta24_e
+```
+
+
 You can also use the constant efficiency used by [Pfrommer et al. (2017)](https://ui.adsabs.harvard.edu/abs/2017MNRAS.465.4500P/abstract):
 
 ```@docs
@@ -97,7 +104,13 @@ kr_fitting_function
 Another parameter in the acceleration efficiency is the shock obliquity. Here we used the results from [Pais et al. (2019)](http://arxiv.org/abs/1907.04300) who fit a functional form to the data by [Caprioli&Spitkovsky (2014)](https://ui.adsabs.harvard.edu/abs/2014ApJ...783...91C/abstract).
 
 ```@docs
-η_B
+Pais2018_t
+```
+
+Or for electrons we supply the model by Gupta et al. (2024).
+
+```@docs
+Gupta2024_t
 ```
 
 ## Ions
@@ -114,7 +127,7 @@ Ions are found to be accelerated primarily at quasi-parallel shocks. We provide
 
 ## Electrons
 
-Electrons are found to be accelerated primarily at quasi-perpendicular shocks. We provide two helper functions for this.
+Electron acceleration can be modeled via
 
 ```@docs
 ηB_acc_e
@@ -131,13 +144,14 @@ To use for example the mach number dependent model by [Kang & Ryu (2013)](https:
 ```julia
 using DiffusiveShockAccelerationModels
 
-ηM_model = KR13()  # Mach number dependent model
-Mach = 5.0         # we assume a Mach 5 shock
-θ_B  = 0.1π        # angle between shock normal and magnetic field vector
+ηM_model = KR13()       # Mach number dependent model
+ηM_model = Pais2018_t() # Obliquity dependent model
+Mach = 5.0              # we assume a Mach 5 shock
+θ_B  = 0.1π             # angle between shock normal and magnetic field vector
 X_cr = 0.0         # X_cr = P_cr / P_th -> in this case no pre-existing CRs
 
 # magnetic field angle dependent acc. efficiency
-ηB   = ηB_acc_p(θ_B)  
+ηB   = ηB_acc_p(ηB_model, θ_B)  
 
 # Mach number dependent acc. efficiency
 ηM   = η_Ms(ηM_model, Mach, X_cr)
diff --git a/src/DiffusiveShockAccelerationModels.jl b/src/DiffusiveShockAccelerationModels.jl
index c9eeddb..9f57b79 100644
--- a/src/DiffusiveShockAccelerationModels.jl
+++ b/src/DiffusiveShockAccelerationModels.jl
@@ -5,7 +5,7 @@ export AbstractShockAccelerationEfficiency,
     # efficiency models
     Kang07, KR13, CS14, Ryu19, P16, 
     Kang24_p, Kang24_e,
-    Gupta24_p, Gupta24_e, 
+    Gupta24_e, 
     Gupta2024_t, Pais2018_t, 
     # mach nummber dependent efficiency 
     η_Ms, η_Ms_acc, η_Ms_reacc,
@@ -98,7 +98,7 @@ using PrecompileTools    # this is a small dependency
 @setup_workload begin
     # Putting some things in `setup` can reduce the size of the
     # precompile file and potentially make loading faster.
-    η_models = [Kang07(), KR13(), CS14(), Ryu19(), Kang24_p(), Kang24_e(), Gupta24_p(), Gupta24_e()]
+    η_models = [Kang07(), KR13(), CS14(), Ryu19(), Kang24_p(), Kang24_e(), Gupta24_e()]
     B_models = [Pais2018_t(), Gupta2024_t()]
 
     @compile_workload begin
diff --git a/src/mach_models/Gupta24.jl b/src/mach_models/Gupta24.jl
index 91344e4..f6c35a6 100644
--- a/src/mach_models/Gupta24.jl
+++ b/src/mach_models/Gupta24.jl
@@ -1,43 +1,3 @@
-"""
-    Gupta24_p(X_cr::T=1.0, η_max::T=0.03) where T
-
-Efficiency model for protons by Gupta, Caprioli & Sptikovsky (2024)
-
-## Values 
-- `X_cr`: P_cr / P_th defined in model for re-acceleration. Basis for interpolation between acceleration and re-acceleration efficiency.
-- `η_max`: Maximum efficiency defined in the model
-"""
-struct Gupta24_p{T} <: AbstractShockAccelerationEfficiency
-    X_cr::T
-    η_max::T
-
-    Gupta24_p(X_cr::T = 1.0, η_max::T = 0.1) where {T} = new{T}(X_cr, η_max)
-end
-
-"""
-    η_Ms_acc(η_model::Gupta24_p, M::Real)
-
-Initial acceleration efficiency model for protons by Gupta, Caprioli & Sptikovsky (2024)
-"""
-function η_Ms_acc(η_model::Gupta24_p, M::Real)
-    if M < 2.0
-        return 0
-    else
-        return η_model.η_max
-    end
-end
-
-"""
-    η_Ms_reacc(η_model::Gupta24_p, M::Real)
-
-Reacceleration efficiency for model by Kang (2024), identical to acceleration efficiency.
-"""
-function η_Ms_reacc(η_model::Gupta24_p, M::Real)
-    η_Ms_acc(η_model, M)
-end
-
-
-
 """
     Gupta24_e(X_cr::T=1.0, η_max::T=0.0004871685) where T
 

From f6bc5e88a41bdcbc514ae105d3e416c8ce712ff0 Mon Sep 17 00:00:00 2001
From: LudwigBoess <lboess@usm.lmu.de>
Date: Thu, 16 Jul 2026 18:24:47 +0200
Subject: [PATCH 7/7] docs fix

---
 docs/src/index.md | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/docs/src/index.md b/docs/src/index.md
index f7070e3..0de8972 100644
--- a/docs/src/index.md
+++ b/docs/src/index.md
@@ -101,7 +101,13 @@ kr_fitting_function
 
 # Magnetic field angle dependent efficiency models
 
-Another parameter in the acceleration efficiency is the shock obliquity. Here we used the results from [Pais et al. (2019)](http://arxiv.org/abs/1907.04300) who fit a functional form to the data by [Caprioli&Spitkovsky (2014)](https://ui.adsabs.harvard.edu/abs/2014ApJ...783...91C/abstract).
+Another parameter in the acceleration efficiency is the shock obliquity. 
+
+```@docs
+η_B
+```
+
+Here we provide the results from [Pais et al. (2019)](http://arxiv.org/abs/1907.04300) who fit a functional form to the data by [Caprioli&Spitkovsky (2014)](https://ui.adsabs.harvard.edu/abs/2014ApJ...783...91C/abstract).
 
 ```@docs
 Pais2018_t