Skip to content

Update plug-in manifest metadata and remove stale code #13

Description

@LostOne1000

Priority

Low

Summary

The plug-in contains placeholder or outdated project metadata and several minor maintenance items.

Current findings

lightroom-llama.lrplugin/Info.lua

Placeholder description:

LrPluginDescription =
    "Description of your Lightroom plugin"

Outdated repository URL:

LrPluginInfoUrl =
    "https://github.com/thejoltjoker/lightroom-llama"

Provider URL uses unsecured HTTP:

LrPluginInfoUrlProvider =
    "http://www.thejoltjoker.com"

lightroom-llama.lrplugin/LrLlama.lua

Stale TODO:

-- TODO Add keywords

Keywords are already implemented.

Potentially unused imports:

local LrErrors = import "LrErrors"
local LrBinding = import "LrBinding"

Global JSON assignment:

JSON = ...

This should be module-local unless global access is intentionally required.

Expected behavior

Manifest metadata should accurately identify the current project, and obsolete code should be removed.

Implementation notes

  • Replace the placeholder description with an accurate plug-in description.
  • Update the project URL to the current repository:
    • LostOne1000/lightroom-llama
  • Review the provider URL and use HTTPS when available.
  • Remove the stale keyword TODO.
  • Confirm and remove unused imports.
  • Change the JSON object to:
local JSON = ...
  • Review version numbering if these changes are included in a release.

Acceptance criteria

  • The plug-in description accurately describes Lightroom Llama.
  • The GitHub project URL points to the active repository.
  • The provider URL is current and uses HTTPS when supported.
  • The stale TODO is removed.
  • Unused imports are removed.
  • JSON does not unnecessarily pollute the global Lua namespace.
  • The plug-in still loads successfully in Lightroom Classic.

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentationenhancementNew feature or request

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions