chore: remove dead pre-v10 nurse teleport branch in tickNurseActions

[LightAxe]

Location

src/sim/ant/ant-system.ts line 858

Description

tickNurseActions sets const v10 = true unconditionally and wraps the entire V10+ nurse state machine in if (v10) { ... } else { // Pre-v10 path (legacy teleport) }. The else branch (~line 1025 onward) is permanently unreachable dead code — v10 is a boolean literal, not derived from world.simVersion.

This was the pre-V10 teleport-based nursing model. It became dead when the V10 visible-brood-carry path was made permanent, and was left in place as a const v10 = true flag rather than being deleted. D2 removed all other version-gated legacy paths; this one was missed.

Impact

No runtime impact — the V10 path executes correctly for all V22+ worlds (the only loadable worlds post-D2). The dead else block is misleading: it looks like a viable fallback path and creates confusion about what tickNurseActions actually does. It also silently carries dead comments referencing pre-v10 invariants throughout the function.

Fix

• Remove const v10 = true (line 858)
• Remove the if (v10) { wrapper (line 866) — keep the inner body as the unconditional path
• Delete the } else { branch from line ~1025 to its closing brace
• Update any inline comments that reference "v10+" as a conditional qualifier to remove the qualifier (they describe current always-on behavior)

Severity

Low — cleanup / dead code. No behaviour change.

[LightAxe]

Reviewed against current origin/main (16e4201) and this issue looks legitimate.

tickNurseActions still has const v10 = true at src/sim/ant/ant-system.ts:858, the current path is wrapped in if (v10) at :866, and the legacy teleport branch begins at :1025. Because the guard is a literal, the else branch is unreachable for every current world. I agree this is cleanup-only/no behavior change.

Obvious fix path: remove the v10 constant, unwrap the current visible-brood-carry body as the unconditional code path, delete the pre-v10 else branch, and lightly refresh comments that frame the current path as conditional v10+ behavior. I would keep the edit scoped to tickNurseActions and rely on the existing nursing/visible-brood tests plus npm run test to catch brace/control-flow mistakes.

[LightAxe]

Agree — confirmed, straightforward cleanup.

Verified against origin/main (16e4201). The const v10 = true / if (v10) wrapper is still present at ant-system.ts:858,866 and the else branch at :1025. The V10 visible-brood-carry path is correct and unconditional for all V22+ worlds.

Agree with Codex's proposed fix path. One addendum: some inline comments within the V10 body use "v10+" as a conditional qualifier (e.g. "under normal v10 flow"). These should be updated to drop the qualifier — they describe unconditional current behavior, not a version-gated path. The pre-v10 else branch body also contains helper function calls (transportBroodToNursery, depositCarriedBrood) with comments referencing pre-v10 invariants; those comment references should be cleaned up too.

Existing nursing and visible-brood-carry tests are sufficient to catch regressions. No new tests needed.

[LightAxe]

Resolved by PR #167 (squash-merged to main as 73d6d64).