From 5bd358fcd8637584610548a75a066a4ceff1a867 Mon Sep 17 00:00:00 2001 From: Charles-Edouard de la Vergne Date: Mon, 22 Jun 2026 11:52:33 +0200 Subject: [PATCH] WUI: only deploy GitHub Pages from develop The github-pages environment protection rules only allow the develop branch, so deploying on a push to master (e.g. when merging develop into master) was rejected. Keep building on master/PRs for validation, but gate the deploy job to develop. --- .github/workflows/wui.yml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/wui.yml b/.github/workflows/wui.yml index c4a9b66..a4b1e16 100644 --- a/.github/workflows/wui.yml +++ b/.github/workflows/wui.yml @@ -27,7 +27,7 @@ jobs: working-directory: clients/wui/ steps: - name: Clone - uses: actions/checkout@v6 + uses: actions/checkout@v7 - name: Set up Node uses: actions/setup-node@v6 with: @@ -57,8 +57,10 @@ jobs: name: Deploy to GitHub Pages runs-on: ubuntu-latest needs: build - # Build on PRs for validation, but only deploy on pushes / manual runs. - if: github.event_name != 'pull_request' + # Build on PRs and on master for validation, but only deploy from develop: + # the github-pages environment protection rules only allow that branch, so a + # push to master (e.g. a merge) would otherwise fail the deployment. + if: github.event_name != 'pull_request' && github.ref == 'refs/heads/develop' environment: name: github-pages url: ${{ steps.deployment.outputs.page_url }}