Trying to fix a small inconsistency with retail - how do repo maintainers want it done? #10562
greentchristian-LSB
started this conversation in
General
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Since trying to amend my commit message to be more in-line with the checks borked up my PR, I want to make sure I address this tiny accuracy fix in the way that it should be fixed before I try again.
When you start Records of Eminence, it plays a slightly different CS depending on if you have started the tutorial quest or not. To the best of my knowledge, this is the only RoE objective that has a CS.
Presently, the logic for that CS is in the NPC scripts for Isakoth, Rolandienne, and Fhelm. The change I proposed added a line to the start of that CS to determine if the tutorial had been started, and provide the appropriate first option for the event.
I was told to move it into the tutorial, but you can start RoE without having started the tutorial - that's the whole point behind the variant CS; in retail, the RoE NPC tells you that you jumped ahead and should start the tutorial; this is more a tweak to RoE than the tutorial.
The difficulty in where to put it is that this is a unique event - all other RoE objectives simply tally, complete, and give you your award. This is the only one that plays a CS as part of completion. If it's not to be kept in the NPC scripts, then turning it into a hidden quest of its own ("Start_RoE.lua" maybe?) would seem to be the way to do it, unless there's a way to play an event as part of the 'reward' for finishing a RoE objective.
Beta Was this translation helpful? Give feedback.
All reactions