Skip to content

More consistency with templating #29

Description

@mantaraya36

Gamma uses in most of its classes a template type Tv to identify the value type and a Tp type to identify parameter types.

There are a few classes that don't follow this convention (that I have found in a quick scan, there may be others...):

  • Chorus, FreqShift, Quantizer, Pluck, in Effects.h : parameters are float not Tp
  • ChebyN, Chirp in Effects.h : both parameters and values are templated to the same type
  • MonoSynth, Biquad3 in Effects.h : parameters and values are float.
  • Pan, AM in Effects.h : is only templated with T used for parameters. The value is templated not for the class but for the individual functions. Maybe for consistency the class should be templated as others?

I think making this consistent throughout will add significant ease in the usage of Gamma as the documentation will have to be checked less often.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions