RoomInstance Preview displaying wrong side of room

[stuff4mike]

Godot version

4.6.1

MetSys version

1.7

Issue description

Hi,

I have an issue where the room instance (preview) is showing the incorrect side of the previewed room.

For the screenshot below:
In Room B, the left side transition shows a preview of the left side of Room A, where it should show a preview of the right side of Room A. I'm not sure if this is a known issue or an isolated issue. I haven't modified any code relating to this in the addon.

I am using v1.7 of the addon, which included a fix for moving and dragging rooms in the Map Editor.

Thank you so much in advance!

Mike

[KoBeWi]

Can't reproduce it. Are you able to share the bugged part of the map?

[stuff4mike]

Hi KoBeWi,

So sorry for the late reply . I got sidetracked with some things. But, I found the issue, although I'm not sure why it's happening...

It happens when objects are children of a canvas layer. I separate objects into canvas layers for rendering and lighting purposes. So, in the example below I setup two stripped down levels.

MAP SETUP

LEVELS T1 and T2 - works fine

LEVELS T1 and T2 - preview is incorrect, as can be seen in second image where t2 previews t1 (on the left)

• the only difference is the setup in t1, where the sprites are children of a canvas layer

If you would like the t1.tscn and t2.tscn files let me know. I'm not sure how to share them on here.

Thank you!

Mike

[KoBeWi]

Room previews are viewports that show part of the neighboring room. The room's scene is added to the viewport and then moved so that the relevant part is inside the preview area. If a node's transform is affected in any way (is inside CanvasLayer, or a Node parent discards it), it won't be correctly moved inside the preview.

You can workaround it by reparenting the affected nodes when inside preview. Something like this should work

@tool
extends CanvasLayer

func _ready() -> void:
	if Engine.is_editor_hint() and get_tree().edited_scene_root != owner:
		await get_parent().ready
		
		for child in get_children():
			child.reparent(get_parent())
		queue_free()

I can add a custom notification to make managing it easier, if that helps.