Skip to content

[#447] Add hackathon timeline page#453

Open
azizu06 wants to merge 5 commits into
club-site-stagingfrom
club/hackathons-timeline
Open

[#447] Add hackathon timeline page#453
azizu06 wants to merge 5 commits into
club-site-stagingfrom
club/hackathons-timeline

Conversation

@azizu06
Copy link
Copy Markdown
Contributor

@azizu06 azizu06 commented May 22, 2026

Why

Implements the club hackathon timeline page, using the Figma layout and real hackathon data for dates, participants, and project submissions.

What

Closes: #447

  • Adds the /hackathons page with the fixed Figma-based timeline layout.
  • Uses real Knight Hacks event data and Roman numeral labels.

Test Plan

  • pnpm format
  • pnpm --filter=@forge/club lint
  • pnpm --filter=@forge/club typecheck
  • Visual Chrome screenshot at the Figma frame width still rendered correctly.

Checklist

  • Database: No schema changes, OR I ran pnpm db:generate and committed the generated files in packages/db/drizzle/
  • Environment Variables: No environment variables changed, OR I have contacted the Development Lead to modify them on Coolify BEFORE merging.

@azizu06 azizu06 added Feature New Feature or Request Minor Small change - 1 reviewer required UI Changes modifies code in the global UI package labels May 22, 2026
@azizu06 azizu06 self-assigned this May 22, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 22, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 8388e402-71db-463b-af39-3d24828f802d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch club/hackathons-timeline

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@azizu06 azizu06 changed the base branch from main to club-site-staging May 22, 2026 06:18
@azizu06 azizu06 marked this pull request as ready for review May 22, 2026 06:24
Copilot AI review requested due to automatic review settings May 22, 2026 06:24
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new /hackathons page to the Club app implementing a fixed Figma-based “timeline/history” layout with hardcoded hackathon data and associated static assets, plus minor formatting/whitespace cleanups in Cron and Blade.

Changes:

  • Added apps/club/src/app/hackathons/page.tsx implementing the hackathon timeline page layout and content wiring.
  • Added new static asset(s) under apps/club/public/hackathons/ (notably the new logo SVG) used by the new page.
  • Minor formatting-only updates in Blade issue assignee display-name helpers and a whitespace cleanup in CronBuilder.

Reviewed changes

Copilot reviewed 5 out of 20 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
apps/cron/src/structs/CronBuilder.ts Removes stray whitespace in the scheduling loop.
apps/club/src/app/hackathons/page.tsx Introduces the new /hackathons timeline page with Figma-positioned layout, hackathon data, and navigation/footer.
apps/club/public/hackathons/Logo 130.svg Adds a new logo asset used on the hackathons page.
apps/blade/src/app/admin/issues/[id]/page.tsx Formatting-only change (line wrapping) for display name construction.
apps/blade/src/app/_components/issues/issue-fetcher-pane.tsx Formatting-only change (line wrapping) for display name construction.
apps/blade/src/app/_components/issue-calendar/calendar-issue-dialog.tsx Formatting-only change (line wrapping) for display name construction.
Comments suppressed due to low confidence (1)

apps/club/src/app/hackathons/page.tsx:373

  • The card images are rendered with alt="", but they appear to be part of the content (and currently the only place the participant/project counts could exist). If these cards convey information, they need meaningful accessible text (preferably render the numbers as real HTML; at minimum provide descriptive alt text).
                <Image
                  src={`/hackathons/figma-card-real-${index}.png`}
                  alt=""
                  width={row.cardWidth}
                  height={row.cardHeight}
                  className="absolute"
                  sizes={`${Math.ceil(row.cardWidth)}px`}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread apps/club/src/app/hackathons/page.tsx
Comment thread apps/club/src/app/hackathons/page.tsx Outdated
Comment thread apps/club/src/app/hackathons/page.tsx
Comment thread apps/club/src/app/hackathons/page.tsx Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature New Feature or Request Minor Small change - 1 reviewer required UI Changes modifies code in the global UI package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[SPRINT-02] Hackathon Timeline Page

2 participants