[#447] Add hackathon timeline page#453
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Adds a new /hackathons page to the Club app implementing a fixed Figma-based “timeline/history” layout with hardcoded hackathon data and associated static assets, plus minor formatting/whitespace cleanups in Cron and Blade.
Changes:
- Added
apps/club/src/app/hackathons/page.tsximplementing the hackathon timeline page layout and content wiring. - Added new static asset(s) under
apps/club/public/hackathons/(notably the new logo SVG) used by the new page. - Minor formatting-only updates in Blade issue assignee display-name helpers and a whitespace cleanup in CronBuilder.
Reviewed changes
Copilot reviewed 5 out of 20 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/cron/src/structs/CronBuilder.ts | Removes stray whitespace in the scheduling loop. |
| apps/club/src/app/hackathons/page.tsx | Introduces the new /hackathons timeline page with Figma-positioned layout, hackathon data, and navigation/footer. |
| apps/club/public/hackathons/Logo 130.svg | Adds a new logo asset used on the hackathons page. |
| apps/blade/src/app/admin/issues/[id]/page.tsx | Formatting-only change (line wrapping) for display name construction. |
| apps/blade/src/app/_components/issues/issue-fetcher-pane.tsx | Formatting-only change (line wrapping) for display name construction. |
| apps/blade/src/app/_components/issue-calendar/calendar-issue-dialog.tsx | Formatting-only change (line wrapping) for display name construction. |
Comments suppressed due to low confidence (1)
apps/club/src/app/hackathons/page.tsx:373
- The card images are rendered with
alt="", but they appear to be part of the content (and currently the only place the participant/project counts could exist). If these cards convey information, they need meaningful accessible text (preferably render the numbers as real HTML; at minimum provide descriptive alt text).
<Image
src={`/hackathons/figma-card-real-${index}.png`}
alt=""
width={row.cardWidth}
height={row.cardHeight}
className="absolute"
sizes={`${Math.ceil(row.cardWidth)}px`}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Why
Implements the club hackathon timeline page, using the Figma layout and real hackathon data for dates, participants, and project submissions.
What
Closes: #447
/hackathonspage with the fixed Figma-based timeline layout.Test Plan
pnpm formatpnpm --filter=@forge/club lintpnpm --filter=@forge/club typecheckChecklist
pnpm db:generateand committed the generated files inpackages/db/drizzle/