Skip to content

Option list causes crash #1

Description

@KenG98

The following element caused a program crash for me:

link (style no-link-underline):
  content: $$ param character-name
  $$ if param character-name == param page-name:
    option: italic, bold
    color: maroon
  href: $$ param link

Caused

Generation error.
TypeError: obj.option.forEach is not a function
    at Object.getRenderAttributes (/home/ken/.nvm/versions/node/v11.14.0/lib/node_modules/better-html/src/html_utils.js:87:14)
    at renderHtmlObj (/home/ken/.nvm/versions/node/v11.14.0/lib/node_modules/better-html/src/render_html.js:38:17)
    at renderHTML (/home/ken/.nvm/versions/node/v11.14.0/lib/node_modules/better-html/src/render_html.js:20:10)
    at Object.column (/home/ken/.nvm/versions/node/v11.14.0/lib/node_modules/better-html/src/render_html.js:83:35)
    at renderHtmlObj (/home/ken/.nvm/versions/node/v11.14.0/lib/node_modules/better-html/src/render_html.js:41:28)
    at renderHTML (/home/ken/.nvm/versions/node/v11.14.0/lib/node_modules/better-html/src/render_html.js:20:10)
    at obj.map.x (/home/ken/.nvm/versions/node/v11.14.0/lib/node_modules/better-html/src/render_html.js:17:23)
    at Array.map (<anonymous>)
    at renderHTML (/home/ken/.nvm/versions/node/v11.14.0/lib/node_modules/better-html/src/render_html.js:17:14)
    at Object.row (/home/ken/.nvm/versions/node/v11.14.0/lib/node_modules/better-html/src/render_html.js:70:34)

Changing option: italic, bold to option: [italic, bold] fixed it, meaning I've forgotten to parse that comma separated list in compilation and tried to iterate through the values in the list. Changing option to options also results in a problem, it looks like it gets completely ignored.

I'm not sure if this is just in a conditional "if" statement or if it happens elsewhere as well, haven't tested it yet.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions