diff --git a/internal/controller/mongodbbackup_controller.go b/internal/controller/mongodbbackup_controller.go index b73af39..ff82a98 100644 --- a/internal/controller/mongodbbackup_controller.go +++ b/internal/controller/mongodbbackup_controller.go @@ -35,6 +35,7 @@ const ( backupPhaseCompleted = "Completed" backupPhaseFailed = "Failed" + backupPhasePassed = "Passed" backupPhasePending = "Pending" backupPhaseRunning = "Running" backupPhaseRestoring = "Restoring" diff --git a/internal/controller/mongodbbackupverification_controller.go b/internal/controller/mongodbbackupverification_controller.go index f6cfc6a..72fe130 100644 --- a/internal/controller/mongodbbackupverification_controller.go +++ b/internal/controller/mongodbbackupverification_controller.go @@ -237,7 +237,7 @@ func (r *MongoDBBackupVerificationReconciler) Reconcile(ctx context.Context, req v.Status.QueryResults = append(v.Status.QueryResults, results...) if allPassed { - v.Status.Phase = "Passed" + v.Status.Phase = backupPhasePassed } else { v.Status.Phase = backupPhaseFailed } diff --git a/internal/controller/mongodbsharded_controller.go b/internal/controller/mongodbsharded_controller.go index 902ce76..9de0c7b 100644 --- a/internal/controller/mongodbsharded_controller.go +++ b/internal/controller/mongodbsharded_controller.go @@ -82,6 +82,7 @@ func ensureShardedUpgradeStartTime(mdbsh *mongodbv1alpha1.MongoDBSharded) { // +kubebuilder:rbac:groups=networking.k8s.io,resources=networkpolicies,verbs=get;list;watch;create;update;patch;delete // +kubebuilder:rbac:groups=cert-manager.io,resources=certificates,verbs=get;list;watch;create;update;patch;delete +//nolint:gocyclo // 12-step reconcile orchestrator — 본질적 복잡도(step 추출 시 가독성 저하, reconcileShardedCollections 분리 완료) func (r *MongoDBShardedReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) { logger := log.FromContext(ctx) logger.Info("Reconciling MongoDBSharded", "namespace", req.Namespace, "name", req.Name) @@ -838,12 +839,13 @@ func (r *MongoDBShardedReconciler) observeShardedCollections(ctx context.Context // 변환한다. order "1"/"-1" 는 BSON 숫자로, "hashed" 는 문자열로 매핑한다 — // MongoDB shardCollection 명령의 key 도큐먼트 컨벤션. func buildShardKey(fields []mongodbv1alpha1.ShardKeyField) bson.D { + const orderHashed = "hashed" key := make(bson.D, 0, len(fields)) for _, f := range fields { var val any switch f.Order { - case "hashed": - val = "hashed" + case orderHashed: + val = orderHashed case "-1": val = int32(-1) default: // "1"