Fixes for nightly#870
Merged
Merged
Conversation
Since JuliaLang/julia#61527 (1.14.0-DEV.2614), the LowerPTLS pass may emit calls to `jl_get_pgcstack_resolved`, a symbol that only exists within the JIT and cannot be looked up using `jl_cglobal`, causing the ResolveCPUReferences pass to error on such modules (as seen on Windows CI, where the TLS getter cannot be lowered to a TP access). As this pass only rewrites loads from `jl_` bindings, and such JIT-only symbols are only ever called, resolve binding addresses lazily, i.e., only when actually replacing a load. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- suppress the unbound-typevar warning emitted when defining the test method (does not work on 1.12, where `redirect_stderr` does not capture C-level output); - suppress FileCheck diagnostics from always_inline tests that are known to be broken on 1.13+. Also add a regression test for resolving CPU references in modules that call JIT-private `jl_` symbols (JuliaLang/julia#61527). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #870 +/- ##
==========================================
+ Coverage 80.04% 80.24% +0.19%
==========================================
Files 25 25
Lines 4810 4813 +3
==========================================
+ Hits 3850 3862 +12
+ Misses 960 951 -9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.