Make the runtime library disk cache best-effort.#869
Merged
Conversation
The cache directory is shared across processes and can be deleted at any point (e.g. by `reset_runtime()`), racing concurrent compilation. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #869 +/- ##
==========================================
+ Coverage 80.02% 80.06% +0.04%
==========================================
Files 25 25
Lines 4805 4810 +5
==========================================
+ Hits 3845 3851 +6
+ Misses 960 959 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cache directory is shared across processes and can be deleted at any point (e.g. by
reset_runtime()), racing concurrent compilation.Hopefully fixes a crash seen on CUDA.jl CI.
Won't be relevant anymore soon, after #794 the runtime is managed by Julia, but let's still fix this for now.