Migrate to Tracking 2 (GNSSSignals 2, GNSSDecoder 1.3)#37
Merged
Conversation
Bump GNSSSignals to 2, GNSSDecoder to 1.3 and Tracking to 2, and adapt the package to the GNSSSignals 2 API (AbstractGNSS -> AbstractGNSSSignal, GPSL1 -> GPSL1CA). Tracking is made a weak dependency: the SatelliteState convenience constructor that converts a Tracking sat state now lives in a package extension (PositionVelocityTimeTrackingExt), so the core package no longer pulls in Tracking. The extension binds to TrackedSat (Tracking 2) or SatState (Tracking <= 1) via isdefined. Tracking is added to the test target and a test exercises the extension. The GNSSDecoder test fixtures are converted from positional to keyword constructors so they survive GNSSDecoder's struct-field growth. BREAKING CHANGE: drops support for GNSSSignals 1 and Tracking 1; the core API now requires the v2 ecosystem. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #37 +/- ##
==========================================
+ Coverage 88.57% 89.38% +0.81%
==========================================
Files 4 5 +1
Lines 245 245
==========================================
+ Hits 217 219 +2
+ Misses 28 26 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Convert the GPSL1Data/GalileoE1BData fixtures from positional to keyword constructors, use the zero-arg GalileoE1BCache, and switch GPSL1() to GPSL1CA(), matching the test-suite migration so the AirspeedVelocity benchmark builds against the v2 ecosystem. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
AirspeedVelocity runs the PR's benchmark script against both the base and PR revisions, which resolve different GNSSSignals major versions. Select GPSL1CA (GNSSSignals 2) or GPSL1 (GNSSSignals 1) at load time so the fixtures build under either revision. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates PositionVelocityTime to the v2 ecosystem — Tracking 2.0.0, GNSSSignals 2.2.2, GNSSDecoder 1.3.0 (the versions that resolve together). This supersedes the CompatHelper-only bump in #36, which couldn't pass on its own: Tracking 2 requires GNSSSignals 2, which forced a wider migration.
Changes
GNSSSignals→2,GNSSDecoder→1.3,Tracking→2.AbstractGNSS→AbstractGNSSSignal,GPSL1→GPSL1CA.SatelliteState(decoder, system, sat_state)), which now lives in a package extension (PositionVelocityTimeTrackingExt). The core package no longer pulls in Tracking. The extension binds toTrackedSat(Tracking 2) orSatState(Tracking ≤ 1) viaisdefined.test/tracking_ext.jlexercising the extension;GPSL1()→GPSL1CA(). The GNSSDecoder fixtures intest/pvt.jlwere converted from positional to keyword constructors so they survive GNSSDecoder's struct-field growth (values preserved exactly).Validation
Pkg.test()resolving the full v2 set passes: Aqua 11/11, PVT Galileo+GPS 42/42, week-rollover 12/12, Tracking-2 extension 7/7.Note
🤖 Generated with Claude Code