Skip to content

Missing square of gradients? #17

Description

@atonderski

Hi,

Thanks for the very interesting work!

I am confused about one thing. In the paper (e.g. equation 11) the hessian is approximated by the square of the gradients, right? However, in the implementation it seems to be approximated using the signed (unsquared) gradient. Am i misunderstanding either the code or the paper? If not, what is the reason behind this? See this code for example (although the same implementation appears in a couple of places)
https://github.com/JiangWenPL/FisherRF/blob/715b76b786010918083604ba9de3c6609606c11b/active/H_reg.py#L69C1-L72C1

Thanks in advance,
Adam

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions