Skip to content

Support VERSION file #1

@slominskir

Description

@slominskir

All the other workflows function via a VERSION file that the build tools can read:

Java:
https://github.com/JeffersonLab/java-workflows/blob/33e897c6a282e23be00ea1668255246f91b03527/build.gradle#L7

Python:
https://github.com/JeffersonLab/jaws-libp/blob/52e756c590d260a1116640b11e078dd591485f9f/pyproject.toml#L7
and
https://github.com/JeffersonLab/jaws-libp/blob/52e756c590d260a1116640b11e078dd591485f9f/pyproject.toml#L39-L40

This apparently isn't going to work in NodeJS with NPM:
npm/npm#7118

At the moment this means users need to bump the version in package.json and commit FIRST, then proceed with VERSION file.

Note: You also must run npm i to bump the version in package-lock.json with the value updated in package.json. The node version command can help here to do both simultaneously, but it also creates a Git tag as well by default, which we don't want if we rely on a separate GitHub action for that.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions