From e75365010ced586fb9ac7881a64e21b23dc10e2e Mon Sep 17 00:00:00 2001 From: JSONbored <49853598+JSONbored@users.noreply.github.com> Date: Fri, 31 Jul 2026 05:02:15 -0700 Subject: [PATCH] =?UTF-8?q?fix(ci):=20unbreak=20main=20=E2=80=94=20drop=20?= =?UTF-8?q?the=20unused=20MCP=5FSERVER=5FNAME=20export?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit dead-exports:check, part of test:ci, is red on a clean main, so every open PR inherits the failure and none can go green. Third instance of this class after #9944 and #10109. #10177 added `export const MCP_SERVER_NAME` in src/mcp/server.ts. Both readers live in that same file -- the handshake's serverInfo.name and the analytics property builder -- so the export has no consumer. CHAT_GROUNDING_MCP_SERVER_NAME in the engine is a separate symbol, not this one re-exported. No behaviour change: the constant and both call sites are untouched, and its "one constant so the handshake and the dashboards cannot disagree" rationale still holds. It is simply module-local now. Closes #10194 --- src/mcp/server.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/mcp/server.ts b/src/mcp/server.ts index 2d956990b..93e6c5a86 100644 --- a/src/mcp/server.ts +++ b/src/mcp/server.ts @@ -839,8 +839,9 @@ export function isMcpAdminEnabled(env: Env): boolean { /** The MCP `serverInfo.name` this server reports, and the `$mcp_server_name` its analytics carry. * One constant so the handshake a client sees and the dashboards an operator reads can never - * disagree about what this server is called. */ -export const MCP_SERVER_NAME = "loopover"; + * disagree about what this server is called. Module-local: both readers (the handshake's serverInfo and + * the analytics property builder) live in this file, and #10177 exported it without a consumer outside it. */ +const MCP_SERVER_NAME = "loopover"; export class LoopoverMcp { private accessScopePromise: Promise | null = null;