From 769cca34f31c7de0d9256eac5701856d14dfeaa7 Mon Sep 17 00:00:00 2001 From: Francois Hebert Date: Fri, 10 Jul 2026 14:38:40 -0600 Subject: [PATCH 1/2] Fix missing include --- src/soca/Utils/OceanSmoother.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/src/soca/Utils/OceanSmoother.cc b/src/soca/Utils/OceanSmoother.cc index e6027a2b3..8e737bdb4 100644 --- a/src/soca/Utils/OceanSmoother.cc +++ b/src/soca/Utils/OceanSmoother.cc @@ -12,6 +12,7 @@ #include "oops/base/GeometryData.h" #include "oops/generic/Diffusion.h" #include "oops/util/FieldSetHelpers.h" +#include "oops/util/Logger.h" #include "soca/Utils/OceanSmoother.h" From fe99b4c57f7e0c479746aaacc4d108d0859bc5f9 Mon Sep 17 00:00:00 2001 From: Francois Hebert Date: Fri, 10 Jul 2026 14:46:35 -0600 Subject: [PATCH 2/2] Use floating-point abs --- .../ParametricOceanStdDev/ParametricOceanStdDev.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/soca/SaberBlocks/ParametricOceanStdDev/ParametricOceanStdDev.cc b/src/soca/SaberBlocks/ParametricOceanStdDev/ParametricOceanStdDev.cc index fc0b4f817..4d557dde8 100644 --- a/src/soca/SaberBlocks/ParametricOceanStdDev/ParametricOceanStdDev.cc +++ b/src/soca/SaberBlocks/ParametricOceanStdDev/ParametricOceanStdDev.cc @@ -5,6 +5,8 @@ * which can be obtained at http://www.apache.org/licenses/LICENSE-2.0. */ +#include + #include "oops/util/Logger.h" #include "oops/util/Timer.h" @@ -144,7 +146,7 @@ ParametricOceanStdDev::ParametricOceanStdDev( double sstVal = v_sstErr(i, 0); for (size_t z = 0; z < levels; z++) { // step 1: calc value from dT/dz - auto val = abs(tocnParams.dz.value() * v_dtdz(i, z)); + auto val = std::abs(tocnParams.dz.value() * v_dtdz(i, z)); // step 2: calc a min from the e-folding scale, and min SST value auto localMin = minVal + (sstVal - minVal) * exp(-v_depth(i, z) / efold);