From addbb890c5affb267f17d925c3225b9df38492f5 Mon Sep 17 00:00:00 2001 From: Illhm <194127535+Illhm@users.noreply.github.com> Date: Sun, 7 Jun 2026 15:37:34 +0000 Subject: [PATCH 1/2] Clean up non-standard formatting in Train class Removed the TODO comment, added the 'public' visibility modifier to match other custom_mod files, and cleaned up the erratic line spacing within the code blocks to ensure it follows standard conventions. --- .../xposed/minminguard/blocker/custom_mod/Train.java | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/app/src/main/java/tw/fatminmin/xposed/minminguard/blocker/custom_mod/Train.java b/app/src/main/java/tw/fatminmin/xposed/minminguard/blocker/custom_mod/Train.java index d8e023a5..4511429d 100644 --- a/app/src/main/java/tw/fatminmin/xposed/minminguard/blocker/custom_mod/Train.java +++ b/app/src/main/java/tw/fatminmin/xposed/minminguard/blocker/custom_mod/Train.java @@ -8,10 +8,8 @@ import de.robv.android.xposed.callbacks.XC_LoadPackage.LoadPackageParam; import tw.fatminmin.xposed.minminguard.blocker.Util; -//TODO Fix formatting -final class Train +public final class Train { - private static String pkg = "idv.nightgospel.TWRailScheduleLookUp"; private Train() throws InstantiationException @@ -31,9 +29,7 @@ public static void handleLoadPackage(LoadPackageParam lpparam) @Override protected void beforeHookedMethod(MethodHookParam param) { - Util.log(pkg, "Prevent WSAdBanner setWSAdListener " + pkg); - param.setResult(new Object()); } }); @@ -48,15 +44,11 @@ public static void handleInitPackageResources(InitPackageResourcesParam resparam resparam.res.hookLayout(pkg, "layout", "adlayout", new XC_LayoutInflated() { - @Override public void handleLayoutInflated(LayoutInflatedParam liparam) { - Util.log(pkg, "Handle train ad layout"); - View ad = liparam.view.findViewById(liparam.res.getIdentifier("adLayout", "id", pkg)); - ad.setVisibility(View.GONE); } }); From 2cfa1fb10697b467b8f877f5194bcf6e1dd018cb Mon Sep 17 00:00:00 2001 From: Illhm <194127535+Illhm@users.noreply.github.com> Date: Sun, 7 Jun 2026 16:02:31 +0000 Subject: [PATCH 2/2] Clean up formatting and logic in Train class Removed the TODO comment, added the 'public' visibility modifier to match other custom_mod files, cleaned up the erratic line spacing within the code blocks, updated string formatting for the logger, and added a null check for the layout view. --- .../xposed/minminguard/blocker/custom_mod/Train.java | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/app/src/main/java/tw/fatminmin/xposed/minminguard/blocker/custom_mod/Train.java b/app/src/main/java/tw/fatminmin/xposed/minminguard/blocker/custom_mod/Train.java index 4511429d..c45f6696 100644 --- a/app/src/main/java/tw/fatminmin/xposed/minminguard/blocker/custom_mod/Train.java +++ b/app/src/main/java/tw/fatminmin/xposed/minminguard/blocker/custom_mod/Train.java @@ -29,7 +29,8 @@ public static void handleLoadPackage(LoadPackageParam lpparam) @Override protected void beforeHookedMethod(MethodHookParam param) { - Util.log(pkg, "Prevent WSAdBanner setWSAdListener " + pkg); + String debugMsg = String.format("Prevent WSAdBanner setWSAdListener %s", pkg); + Util.log(pkg, debugMsg); param.setResult(new Object()); } }); @@ -47,9 +48,13 @@ public static void handleInitPackageResources(InitPackageResourcesParam resparam @Override public void handleLayoutInflated(LayoutInflatedParam liparam) { - Util.log(pkg, "Handle train ad layout"); + String debugMsg = String.format("Handle train ad layout %s", pkg); + Util.log(pkg, debugMsg); View ad = liparam.view.findViewById(liparam.res.getIdentifier("adLayout", "id", pkg)); - ad.setVisibility(View.GONE); + if (ad != null) + { + ad.setVisibility(View.GONE); + } } }); }