Skip to content

Create service path directories#22512

Queued
MikeMcQuaid wants to merge 1 commit into
mainfrom
services-create-path-dirs
Queued

Create service path directories#22512
MikeMcQuaid wants to merge 1 commit into
mainfrom
services-create-path-dirs

Conversation

@MikeMcQuaid
Copy link
Copy Markdown
Member

Fixes #22501

  • Avoid service startup failures when explicit DSL paths need dirs
  • Keep creation scoped to service block path fields
  • Cover path inference and load-time creation in service specs

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them? Performance claims (e.g. "this is faster") must include Hyperfine benchmarks.
  • Have you written new tests (excluding integration tests) for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

  • AI was used to generate or assist with generating this PR.

OpenAI Codex 5.5 xhigh with local review and testing.


@github-code-quality
Copy link
Copy Markdown

github-code-quality Bot commented Jun 2, 2026

Code Coverage Overview

Languages: Ruby

Ruby / code-coverage/simplecov

The overall coverage in the branch remains at 78%, unchanged from the branch.

Show a code coverage summary of the most impacted files.
File 53d2800 e6dd289 +/-
services/system.rb 85% 81% -4%
services/cli.rb 63% 62% -1%
services/formula_wrapper.rb 86% 86% 0%
service.rb 95% 95% 0%
services/system/systemctl.rb 87% 93% +6%

Updated June 02, 2026 16:28 UTC
Code Coverage is in Public Preview. Learn more and provide us with your feedback.

- Avoid service startup failures when explicit DSL paths need dirs
- Keep creation scoped to `service` block path fields
- Cover path inference and load-time creation in service specs
@MikeMcQuaid MikeMcQuaid force-pushed the services-create-path-dirs branch from de90a6f to e6dd289 Compare June 2, 2026 16:11
@MikeMcQuaid MikeMcQuaid enabled auto-merge June 2, 2026 16:31
@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Jun 2, 2026
Any commits made after this event will not be merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Brew should automatically create the paths used in service blocks

2 participants