Image/Label Constructors

[Artur-man]

I do not remember if we had a reason to throwing errors when the input of image/label elements are just single arrays.

spatialdataR/tests/testthat/test-sdarray.R

Lines 25 to 28 in 772f956

	rgb <- \(n) sample(seq_len(255), n, replace=TRUE)
	mat <- array(rgb(3*20*20), dim=c(3,20,20))
	# invalid
	expect_error(SpatialDataImage(mat))

A single 3 dimensional array (or 2 for labels) should be a reasonable input.

[HelenaLC]

Wasnt it bc at somepoint Luca said there must be multiscales, even if its single scale? Dont recall another reason

[HelenaLC]

It does say expect_silent(SpatialDataImage(list(mat))) so what's the issue, can you clarify? I guess yes, we could call list() internally when the input is just an array

[Artur-man]

I was talking about the first test that supposed to throw an error:

rgb <- \(n) sample(seq_len(255), n, replace=TRUE)
mat <- array(rgb(3*20*20), dim=c(3,20,20))
# invalid
expect_error(SpatialDataImage(mat))

If I run this, I get.

> SpatialDataImage(mat)
Error in validObject(.Object) : 
  invalid class “SpatialDataImage” object: invalid object for slot "data" in class "SpatialDataImage": got class "array", should be or extend class "list"

but it feels like this array can be wrapped in a list with one element, instead of being rejected.

Not a big deal, we wrote these tests more than a year ago, wanted to check in.

[HelenaLC]

Yes agree. See second comment. Easy fix & thanks for the catch :))

[Artur-man]

We are really close to having everything lazy :D

[HelenaLC]

SpatialDataImage/Label now accept single arrays. If we run into similar issue, can easily update to accept other data types that would/should work. Close or suggest further improvement.