Skip to content

Prevent crash on not implemented optional HPickerViewDelegates #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sudo-plz wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Prevent crash on not implemented optional HPickerViewDelegates #7

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b17c1e
Prevent crash on not implemented optional HPickerViewDelegate
Feb 2, 2015
ed52d37
Fix incorrect respondsToSelector
sudo-plz Feb 2, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions HorizontalPickerView/HorizontalPickerView.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,12 +236,15 @@ - (NSInteger)numberOfRowsInCollectionViewController:(HPCollectionVC *)collection

- (NSString *)collectionViewController:(HPCollectionVC *)collectionVC titleForRow:(NSInteger)row
{
return [_delegate pickerView:self titleForRow:row];
if ([_delegate respondsToSelector:@selector(pickerView:titleForRow:)])
return [_delegate pickerView:self titleForRow:row];
return @"";
}

- (void)collectionViewController:(HPCollectionVC *)collectionVC didSelectRow:(NSInteger)row
{
[_delegate pickerView:self didSelectRow:row];
if ([_delegate respondsToSelector:@selector(pickerView:didSelectRow:)])
[_delegate pickerView:self didSelectRow:row];
}

#pragma mark - External affairs
Expand All @@ -268,7 +271,8 @@ - (void)selectRow:(NSInteger)row animated:(BOOL)animated;
NSIndexPath *indexPath = [NSIndexPath indexPathForItem:row inSection:0];
[self.collectionController changeSelectionInCollectionView:self.collectionController.collectionView indexPath:indexPath];

[_delegate pickerView:self didSelectRow:row];
if ([_delegate respondsToSelector:@selector(pickerView:didSelectRow:)])
[_delegate pickerView:self didSelectRow:row];
}
}

Expand Down Expand Up @@ -375,7 +379,7 @@ - (id)initWithFrame:(CGRect)frame
self.autoresizingMask = UIViewAutoresizingFlexibleWidth;
self.backgroundColor = [UIColor clearColor];

CAGradientLayer *gradientLayer = (CAGradientLayer *)self.layer;
CAGradientLayer *gradientLayer = (CAGradientLayer *)self.layer;
gradientLayer.locations = @[@0.0f, @0.015f, @0.025f, @0.5f, @0.5f, @1.0f];

gradientLayer.colors =
Expand Down