[UI]: File sync UI inconsistency, swap "unknown" type errors for small binary previews.

[clayt0nk]

Bug description

Passy version 1.10.1 (not present in dropdown below)

I added a file to desktop Passy, and then synced it with Android Passy. Other things were added and updated in both directions, but the new file does not show up on Android Passy.

Note that when I click on the file on desktop, the text is "Failed to display file", and clicking on "Details" results in something that looks kinda like a traceback, with the first line "unknown entry type".

The file was already included before upload.

Expected outcome

No response

Steps to reproduce

No response

Error log

No response

App version

None

Submission checklist

• I have specified the problem in the issue title
• I have provided a verbose description of the problem

[GleammerRay]

Hello @clayt0nk ! Sorry to hear that, let's see why it failed.

For the file to synchronize and display properly, it must be moved under the "Synchronized Files" root folder in Passy, and have a valid filetype assigned.

If the file is under that root folder, and displays fine on your PC, do you mind sharing the file format extension? Some formats may not be supported for viewing on mobile.

If you can replicate this issue with a non-confidential file from an existing public site, feel free to share the link for me to test. Thank you!

[clayt0nk]

I moved the file into "Synchronized Files" and it now syncs between devices.

There is no file extension, this is not mandatory on Linux, so I guess Passy just assigns it "Unknown" by default. Although it is an encryption key, it is presented here in ASCII form, so I changed the file type to "Plain Text" and it now displays correctly on desktop and mobile. However, I am still getting log errors:

Null check operator used on a null value
#0      PdfTextSearcher._registerForDocumentChanges (package:pdfrx/src/widgets/pdf_text_searcher.dart:176)
#1      new PdfTextSearcher (package:pdfrx/src/widgets/pdf_text_searcher.dart:14)
#2      _PassyFileWidget.textSearcher (package:passy/passy_flutter/widgets/passy_file_widget.dart:55)
#3      _PassyFileWidget.dispose (package:passy/passy_flutter/widgets/passy_file_widget.dart)
#4      StatefulElement.unmount (package:flutter/src/widgets/framework.dart:6033)
#5      _InactiveElements._unmount (package:flutter/src/widgets/framework.dart:2117)
#6      _InactiveElements._unmount.<anonymous closure> (package:flutter/src/widgets/framework.dart:2115)
#7      _RawViewElement.visitChildren (package:flutter/src/widgets/view.dart:574)
#8      _InactiveElements._unmount (package:flutter/src/widgets/framework.dart:2113)
#9      _InactiveElements._unmount.<anonymous closure> (package:flutter/src/widgets/framework.dart:2115)
#10     RootElement.visitChildren (package:flutter/src/widgets/binding.dart:1736)
#11     _InactiveElements._unmount (package:flutter/src/widgets/framework.dart:2113)
#12     _InactiveElements._unmount.<anonymous closure> (package:flutter/src/widgets/framework.dart:2115)

ad nauseum.....

You might want a catch-all "binary" file type even if "Unknown" is supposed to be a valid choice.

[GleammerRay]

Great catch, good to hear it synchronizes properly, and thank you for the log, I'll look into fixing that little error for the next update.

I don't have anything special planned for Passy at the moment, so I wouldn't expect a new release this month. There's no major release in the workings, but I will look at older issues and make a list of what could be improved in terms of UX, I do want to make a small release that cleans it up without adding anything new.

Cheers!