rinex str2time width overflowing field

[ourairquality]

Small nit, might the below change have been intended to be str2time(buff, 2, 27, time, tsys)

src/cpp/common/rinex.cpp
@@ -879,7 +878,7 @@ int decodeObsEpoch(
         if (flag >= 3 && flag <= 5)
             return n;
 
-        if (buff[0] != '>' || str2time(buff, 1, 28, time, tsys))
+        if (buff[0] != '>' || str2time(buff, 2, 29, time, tsys))

[seballgeyer]

Thanks, good catch.

For standard RINEX epoch records this should not have any practical effect. The epoch time field after the leading "> " is 27 characters wide, e.g.

    2019 07 18 00 00  0.0000000

so str2time(buff, 2, 27, time, tsys) would be the field-exact width.

The current str2time(buff, 2, 29, time, tsys) reads two characters beyond that epoch field, which in normal RINEX records are just the separator spaces before the event flag / satellite count. str2time() then uses sscanf(..., "%lf %lf %lf %lf %lf %lf", ...), so after the six time values are parsed, those trailing characters do not affect the result.