Skip to content

Commit 4c1e088

Browse files
bobleerclaude
andcommitted
fix(ci): declare the reqwest edge remote-ssh-concrete now needs
Core boundary check failed: services-integrations keeps every optional runtime dependency owned by an explicit integration feature, and one-click relay deploy started using reqwest to fetch the signed release checksum without registering that edge. Declared rather than worked around. The alternative was to move the fetch into the desktop crate (its only caller) and pass hashes into start_task, but that puts security-critical verification in an API-surface file, away from the contract it protects, and leaks the env-var naming out of the module that consumes it. aes-gcm and rand already list remote-ssh-concrete as an owner in this same rule, so this is the registration path the file establishes, not an exception invented for this change. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
1 parent e2028e7 commit 4c1e088

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

scripts/core-boundaries/rules/feature-rules.mjs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,10 @@ export const optionalDependencyFeatureOwnerRules = [
9494
{ depName: 'oxc', ownerFeatures: ['canvas-runtime'] },
9595
{ depName: 'qrcode', ownerFeatures: ['remote-connect'] },
9696
{ depName: 'rand', ownerFeatures: ['mcp', 'remote-connect', 'remote-ssh-concrete'] },
97-
{ depName: 'reqwest', ownerFeatures: ['announcement', 'browser-control', 'debug-log', 'mcp', 'miniapp-runtime', 'remote-connect', 'review-platform', 'speech', 'web-tools'] },
97+
// remote-ssh-concrete: one-click relay deploy fetches the signed release
98+
// checksum over HTTPS and verifies it on this device, because the target
99+
// server has no minisign and no trust root of its own.
100+
{ depName: 'reqwest', ownerFeatures: ['announcement', 'browser-control', 'debug-log', 'mcp', 'miniapp-runtime', 'remote-connect', 'remote-ssh-concrete', 'review-platform', 'speech', 'web-tools'] },
98101
{ depName: 'rmcp', ownerFeatures: ['mcp'] },
99102
{ depName: 'russh', ownerFeatures: ['remote-ssh-concrete'] },
100103
{ depName: 'russh-keys', ownerFeatures: ['remote-ssh-concrete'] },

0 commit comments

Comments
 (0)