Merge pull request #1663 from wsp1911/pr/permission

feat(permissions): add unified permission controls across product surfaces

Author: wsp1911

scripts/core-boundaries/rules/crate-rules.mjs

@@ -81,7 +81,6 @@ export const lightweightBoundaryRules = [
       'bitfun-services-integrations',
       'bitfun-agent-tools',
       'bitfun-tool-packs',
-      'bitfun-product-domains',
       'bitfun-transport',
       'terminal-core',
       'tool-runtime',

scripts/core-boundaries/rules/feature-rules.mjs

@@ -1,6 +1,14 @@
 // Boundary rules for feature assembly and optional dependency ownership.
 
 export const optionalDependencyFeatureOwnerRules = [
+  {
+    crateName: 'runtime-ports',
+    reason:
+      'runtime-ports may expose product-domain permission ports only through the explicit permission contract slice',
+    dependencies: [
+      { depName: 'bitfun-product-domains', ownerFeatures: ['permission'] },
+    ],
+  },
   {
     crateName: 'core',
     reason:

scripts/core-boundaries/rules/source/forbidden-rules.mjs

@@ -1770,12 +1770,12 @@ export const forbiddenContentRules = [
       {
         regex: /\bpub enum ConfirmationResponse\b/,
         message:
-          'core tool pipeline must not own confirmation channel responses; use bitfun-agent-runtime tool_confirmation',
+          'core tool pipeline must not reintroduce legacy confirmation channel responses; use permission requests',
       },
       {
         regex: /\boneshot::Sender<\s*ConfirmationResponse\s*>/,
         message:
-          'core tool pipeline must not own confirmation wait-channel storage; use bitfun-agent-runtime tool_confirmation',
+          'core tool pipeline must not reintroduce legacy confirmation wait-channel storage; use permission requests',
       },
       {
         regex: /\bArc<DashMap<String,\s*CancellationToken>>\b/,
@@ -2508,7 +2508,7 @@ export const forbiddenContentRules = [
       {
         regex: /ToolConfirmationOutcome::(?:Rejected|ChannelClosed|Timeout)/,
         message:
-          'core tool pipeline must not own confirmation wait-result mapping; use bitfun-agent-runtime',
+          'core tool pipeline must not reintroduce legacy confirmation wait-result mapping; use permission requests',
       },
     ],
   },

scripts/core-boundaries/rules/source/required-rules.mjs

@@ -1822,69 +1822,6 @@ export const requiredContentRules = [
       },
     ],
   },
-  {
-    path: 'src/crates/execution/agent-runtime/src/tool_confirmation.rs',
-    reason:
-      'agent-runtime must own portable tool confirmation planning, failure mapping, and wait-channel lifecycle state',
-    patterns: [
-      {
-        regex: /\bpub struct ToolConfirmationRequestFacts\b/,
-        message: 'missing tool confirmation request facts',
-      },
-      {
-        regex: /\bpub struct ToolConfirmationGateFacts\b/,
-        message: 'missing tool confirmation gate facts',
-      },
-      {
-        regex: /\bpub enum ToolConfirmationGatePlan\b/,
-        message: 'missing tool confirmation gate plan',
-      },
-      {
-        regex: /\bpub enum ToolConfirmationPlan\b/,
-        message: 'missing tool confirmation plan contract',
-      },
-      {
-        regex: /\bpub enum ToolConfirmationOutcome\b/,
-        message: 'missing tool confirmation outcome contract',
-      },
-      {
-        regex: /\bpub enum ToolConfirmationWaitResult\b/,
-        message: 'missing tool confirmation wait-result contract',
-      },
-      {
-        regex: /\bpub enum ToolConfirmationResponse\b/,
-        message: 'missing tool confirmation channel response',
-      },
-      {
-        regex: /\bpub enum ConfirmationFailureKind\b/,
-        message: 'missing tool confirmation failure kind',
-      },
-      {
-        regex: /\bpub struct ToolConfirmationChannelStore\b/,
-        message: 'missing tool confirmation channel store',
-      },
-      {
-        regex: /\bpub fn resolve_tool_confirmation_plan\b/,
-        message: 'missing tool confirmation plan resolver',
-      },
-      {
-        regex: /\bpub fn resolve_tool_confirmation_gate\b/,
-        message: 'missing tool confirmation gate resolver',
-      },
-      {
-        regex: /\bpub fn resolve_confirmation_failure\b/,
-        message: 'missing tool confirmation failure resolver',
-      },
-      {
-        regex: /\bpub fn resolve_confirmation_wait_result\b/,
-        message: 'missing tool confirmation wait-result resolver',
-      },
-      {
-        regex: /\bconfirmation_channel_store_delivers_confirmation_once\b/,
-        message: 'missing confirmation channel delivery regression',
-      },
-    ],
-  },
   {
     path: 'src/crates/execution/agent-runtime/src/checkpoint.rs',
     reason:
@@ -1908,37 +1845,6 @@ export const requiredContentRules = [
       },
     ],
   },
-  {
-    path: 'src/crates/execution/agent-runtime/tests/tool_confirmation_contracts.rs',
-    reason:
-      'agent-runtime tool confirmation owner must keep behavior-equivalence contracts for legacy permission planning and failures',
-    patterns: [
-      {
-        regex: /\bconfirmation_plan_requires_permission_only_when_both_flags_are_true\b/,
-        message: 'missing tool confirmation gate regression',
-      },
-      {
-        regex: /\bconfirmation_gate_preserves_skip_policy_precedence\b/,
-        message: 'missing tool confirmation skip-policy regression',
-      },
-      {
-        regex: /\bconfirmation_gate_requires_confirmation_only_for_permissioned_tools\b/,
-        message: 'missing tool confirmation permissioned-tool regression',
-      },
-      {
-        regex: /\bconfirmation_plan_preserves_legacy_no_timeout_one_year_deadline\b/,
-        message: 'missing tool confirmation no-timeout regression',
-      },
-      {
-        regex: /\bconfirmation_failure_mapping_preserves_legacy_reasons_and_errors\b/,
-        message: 'missing tool confirmation failure mapping regression',
-      },
-      {
-        regex: /\bconfirmation_wait_result_mapping_preserves_legacy_timeout_and_rejection\b/,
-        message: 'missing tool confirmation wait-result mapping regression',
-      },
-    ],
-  },
   {
     path: 'src/crates/execution/agent-runtime/src/scheduler.rs',
     reason:
@@ -2791,27 +2697,15 @@ export const requiredContentRules = [
   {
     path: 'src/crates/assembly/core/src/agentic/tools/pipeline/tool_pipeline.rs',
     reason:
-      'core tool pipeline must delegate portable confirmation planning, failure mapping, and channel ownership to agent-runtime while retaining state/event/tool execution wiring',
+      'core tool pipeline must delegate portable cancellation and retry policy while retaining state/event/tool execution wiring',
     patterns: [
       {
-        regex: /\bresolve_tool_confirmation_plan\b/,
-        message: 'missing tool confirmation plan delegation',
-      },
-      {
-        regex: /\bresolve_confirmation_failure\b/,
-        message: 'missing tool confirmation failure mapping delegation',
-      },
-      {
-        regex: /\bresolve_confirmation_wait_result\b/,
-        message: 'missing tool confirmation wait-result mapping delegation',
+        regex: /\bremote_workspace_route_root_isolated_from_same_local_path\b/,
+        message: 'missing remote workspace permission identity isolation regression',
       },
       {
-        regex: /\bToolConfirmationPlan::Await\b/,
-        message: 'missing tool confirmation await-plan handling',
-      },
-      {
-        regex: /\bToolConfirmationChannelStore\b/,
-        message: 'missing tool confirmation channel owner delegation',
+        regex: /\bonce_and_always_replies_control_execution_and_remembered_grants\b/,
+        message: 'missing permission project and remote grant isolation regression',
       },
       {
         regex: /\bToolCancellationTokenStore\b/,
@@ -5354,10 +5248,6 @@ export const requiredContentRules = [
         regex: /\bpub fn get_tool_spec_is_concurrency_safe\b/,
         message: 'missing pure GetToolSpec concurrency metadata contract',
       },
-      {
-        regex: /\bpub fn get_tool_spec_needs_permissions\b/,
-        message: 'missing pure GetToolSpec permission metadata contract',
-      },
       {
         regex: /\bpub fn validate_get_tool_spec_input\b/,
         message: 'missing pure GetToolSpec input validation contract',
@@ -6627,10 +6517,6 @@ export const requiredContentRules = [
         regex: /\bremote_poll_handler_preserves_missing_workspace_error\b/,
         message: 'missing remote poll missing-workspace regression',
       },
-      {
-        regex: /\bremote_interaction_handler_preserves_default_reject_reason\b/,
-        message: 'missing remote interaction default reject regression',
-      },
     ],
   },
   {
@@ -6950,12 +6836,8 @@ export const requiredContentRules = [
   {
     path: 'src/crates/assembly/core/src/agentic/coordination/scheduler.rs',
     reason:
-      'core scheduler keeps remote queue policy semantics until agent-runtime migration is reviewed',
+      'core scheduler must keep dialog lifecycle and requester-aware cancellation adapters',
     patterns: [
-      {
-        regex: /\bremote_queue_policy_preserves_confirmation_boundary\b/,
-        message: 'missing remote queue policy regression',
-      },
       {
         regex: /\bimpl AgentDialogTurnPort for DialogScheduler\b/,
         message: 'missing dialog lifecycle port implementation',

scripts/core-boundaries/self-test.mjs

@@ -1999,25 +1999,6 @@ export function runManifestParserSelfTest({
       path: 'src/crates/execution/agent-runtime/tests/post_call_hook_execution_contracts.rs',
       contracts: ['successful_tool_post_call_executor_runs_deep_review_measurement_route'],
     },
-    {
-      path: 'src/crates/execution/agent-runtime/src/tool_confirmation.rs',
-      contracts: [
-        'ToolConfirmationRequestFacts',
-        'ToolConfirmationGateFacts',
-        'ToolConfirmationGatePlan',
-        'ToolConfirmationPlan',
-        'ToolConfirmationOutcome',
-        'ToolConfirmationWaitResult',
-        'ToolConfirmationResponse',
-        'ToolConfirmationChannelStore',
-        'ConfirmationFailureKind',
-        'resolve_tool_confirmation_gate',
-        'resolve_tool_confirmation_plan',
-        'resolve_confirmation_failure',
-        'resolve_confirmation_wait_result',
-        'confirmation_channel_store_delivers_confirmation_once',
-      ],
-    },
     {
       path: 'src/crates/execution/agent-runtime/src/user_questions.rs',
       contracts: [
@@ -2154,17 +2135,6 @@ export function runManifestParserSelfTest({
         'ShellType::Custom(name)',
       ],
     },
-    {
-      path: 'src/crates/execution/agent-runtime/tests/tool_confirmation_contracts.rs',
-      contracts: [
-        'confirmation_gate_preserves_skip_policy_precedence',
-        'confirmation_gate_requires_confirmation_only_for_permissioned_tools',
-        'confirmation_plan_requires_permission_only_when_both_flags_are_true',
-        'confirmation_plan_preserves_legacy_no_timeout_one_year_deadline',
-        'confirmation_failure_mapping_preserves_legacy_reasons_and_errors',
-        'confirmation_wait_result_mapping_preserves_legacy_timeout_and_rejection',
-      ],
-    },
     {
       path: 'src/crates/execution/agent-runtime/src/checkpoint.rs',
       contracts: [
@@ -2630,10 +2600,8 @@ export function runManifestParserSelfTest({
     {
       path: 'src/crates/assembly/core/src/agentic/tools/pipeline/tool_pipeline.rs',
       contracts: [
-        'resolve_tool_confirmation_plan',
-        'resolve_confirmation_failure',
-        'resolve_confirmation_wait_result',
-        'ToolConfirmationPlan::Await',
+        'remote_workspace_route_root_isolated_from_same_local_path',
+        'once_and_always_replies_control_execution_and_remembered_grants',
         'should_retry_tool_attempt',
         'retry_delay_ms',
         'build_tool_call_truncation_recovery_notice',
@@ -2734,7 +2702,6 @@ export function runManifestParserSelfTest({
         'render_get_tool_spec_tool_use_message',
         'get_tool_spec_is_readonly',
         'get_tool_spec_is_concurrency_safe',
-        'get_tool_spec_needs_permissions',
         'validate_get_tool_spec_input',
         'build_get_tool_spec_assistant_detail',
         'build_get_tool_spec_duplicate_load_result',
@@ -3032,7 +2999,6 @@ export function runManifestParserSelfTest({
         'remote_poll_handler_preserves_missing_workspace_error',
         'RemoteInteractionRuntimeHost',
         'handle_remote_interaction_command',
-        'remote_interaction_handler_preserves_default_reject_reason',
         'RemoteDefaultModelsConfig',
         'RemoteModelConfig',
         'RemoteModelCatalog',
@@ -3104,7 +3070,6 @@ export function runManifestParserSelfTest({
     {
       path: 'src/crates/assembly/core/src/agentic/coordination/scheduler.rs',
       contracts: [
-        'remote_queue_policy_preserves_confirmation_boundary',
         'AgentDialogTurnPort',
         'AgentLifecycleDeliveryPort',
         'AgentTurnCancellationPort',

src/apps/cli/src/actions.rs

@@ -71,6 +71,7 @@ pub(crate) enum ActionHandler {
     Init,
     History,
     Usage,
+    ToggleAutoApprove,
     Exit,
     Login,
     Logout,
@@ -444,6 +445,21 @@ static ACTION_SPECS: &[ActionSpec] = &[
         shortcut_label: None,
         slash_on_startup: true,
     },
+    ActionSpec {
+        id: "toggle_auto_approve",
+        name: "Auto mode",
+        aliases: &["/auto"],
+        description: "Toggle Auto mode for the current session",
+        contexts: CHAT,
+        availability: ActionAvailability::Idle,
+        handler: ActionHandler::ToggleAutoApprove,
+        default_bindings: &[],
+        fallback_bindings: &[],
+        shortcut_field: None,
+        palette: palette("Session", false),
+        shortcut_label: None,
+        slash_on_startup: false,
+    },
     ActionSpec {
         id: "exit",
         name: "Exit the app",
@@ -1694,6 +1710,16 @@ mod tests {
         );
     }
 
+    #[test]
+    fn auto_mode_is_chat_only_and_idle_only() {
+        assert!(action_for_alias("/auto", ActionContext::Startup).is_none());
+
+        let action = action_for_alias("/auto", ActionContext::Chat).unwrap();
+        assert_eq!(action.handler, ActionHandler::ToggleAutoApprove);
+        assert!(action.available(ActionState::chat(false, false)));
+        assert!(!action.available(ActionState::chat(true, false)));
+    }
+
     #[test]
     fn extension_management_uses_capability_entries_instead_of_external_commands() {
         let tools = action_for_alias("/tools", ActionContext::Chat).unwrap();