able to set-genre an empty genre

[Fureimi]

when I do set-genre and leave the genre empty, the application allows me to do so and when I run list-genre, the new genre will be empty as well.

[soc-se-bot]

Team's Response

Hi! An oversight on our part indeed!

However, we disagree that this is of medium severity.

As seen from the guidelines, this error is unlikely to affect normal operations since users can remove the wrongly inputted space from the genre list. Users can also use the programme as per normal and set the genre of a book to whatever they wish to.

Hope this clarifies!

Items for the Tester to Verify

❓ Issue severity

Team chose [severity.Low]
Originally [severity.Medium]

• I disagree

Reason for disagreement: There are 2 cases which a user might add an empty genre:

1. A user input set-genre, followed by the choice to add a new genre, before pressing enter without typing a genre by accident. This can be fixed by removing the empty genre from the list, so for this case I agree that it will not cause inconvenience.
2. A user input set-genre, followed by the choice to add a new genre, before pressing enter without typing a genre on purpose. Since there is no exception handling for an empty genre, the user might assume this is how you set a book to have no genre, or a user might use an empty genre to represent something else. (For example, not sure genre yet as they haven't read it, etc). By itself this is fine, but this empty genre affects find-genre, as when you input find-genre followed by the empty genre, instead of listing all the books with the empty genre, it lists all books regardless of their genre. So, I believe it should be medium severity due to the lack of exception handling for this case, or any warnings.

---