Skip to content

[Brutal Review] 51 methods potentially missing null validation #342

@sfloess

Description

@sfloess

Severity: HIGH

Found 51 methods accepting object parameters without null checks.

Impact: NullPointerException risk.

Sample findings:

=== Methods without null checks ===
src/main/java/org/flossware/classloader/cache/FileSystemCache.java:38:    public FileSystemCache(Path cacheDirectory) throws IOException {
src/main/java/org/flossware/classloader/cache/FileSystemCache.java:50:    public FileSystemCache(String cacheDirectory) throws IOException {
src/main/java/org/flossware/classloader/cache/FileSystemCache.java:55:    public byte[] get(String className) {
src/main/java/org/flossware/classloader/cache/FileSystemCache.java:78:    public void put(String className, byte[] classData) throws IOException {
src/main/java/org/flossware/classloader/cache/FileSystemCache.java:106:    public boolean contains(String className) {
src/main/java/org/flossware/classloader/cache/FileSystemCache.java:152:    public void remove(String className) throws IOException {
src/main/java/org/flossware/classloader/cache/FileSystemCache.java:164:    private Path getClassFilePath(String className) throws IOException {
src/main/java/org/flossware/classloader/protocol/ProtocolHandlerRegistry.java:36:    public void register(String protocol, Class<? extends ProtocolHandler> handlerClass) {
src/main/java/org/flossware/classloader/protocol/ProtocolHandlerRegistry.java:48:    public void unregister(String protocol) {

Action Required: Add Objects.requireNonNull() or @nullable annotations.


Generated by brutal code review on 2026-05-29 21:25:03

Metadata

Metadata

Assignees

No one assigned

    Labels

    code-qualityCode quality and maintainability issues

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions