Skip to content

chore: address rustfmt + CodeRabbit review debt from PR #750 admin-merge #758

Description

@zackees

Sub-issue of #755 (post-#750 follow-up meta).

What

PR #750 was admin-merged with two CI failures bypassed:

  1. Formatting (rustfmt) — the new task bodies in crates/fbuild-daemon/src/handlers/websockets.rs weren't cargo-fmt'd. Diff sample from the CI log:

    // What I wrote:
    let _ = out_tx_inbound.send(SerialServerMessage::WriteAck {
        success: false,
        bytes_written: 0,
        message: Some(format!("write error: {}", e)),
    });
    
    // What rustfmt wants:
    let _ = out_tx_inbound
        .send(SerialServerMessage::WriteAck {
            success: false,
            bytes_written: 0,
            message: Some(format!("write error: {}", e)),
        });
  2. CodeRabbit review — was still in PENDING state at merge time. Any review comments that landed after the merge are unaddressed.

Acceptance

Why this is a separate sub-issue

These are housekeeping, not behavior changes. Worth a focused 1-2-commit PR so the diff is easy to review and the new green-CI baseline is established before the heavier #756 / #757 work lands on top.

Cross-links

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    Status
    Triage

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions