From 62cecd65aea3f4d98030d38aee3a183ff0f31a19 Mon Sep 17 00:00:00 2001 From: "Vit Horacek (via MelvinBot)" Date: Sat, 30 May 2026 09:11:56 +0000 Subject: [PATCH] Revert "Merge pull request #90365 from Expensify/jpersaud/concierge-enable-notifications-banner" This reverts commit 021bcf37b4129e2f4fb69775dbe1594844df277f, reversing changes made to e2ca8309b4fc91b052288a6577ff31702b205f6d. Co-authored-by: Vit Horacek --- src/ONYXKEYS.ts | 4 - src/components/Banner.tsx | 21 ++--- src/languages/de.ts | 1 - src/languages/en.ts | 4 - src/languages/es.ts | 4 - src/languages/fr.ts | 1 - src/languages/it.ts | 1 - src/languages/ja.ts | 4 - src/languages/nl.ts | 1 - src/languages/pl.ts | 1 - src/languages/pt-BR.ts | 1 - src/languages/zh-hans.ts | 4 - .../LocalNotification/BrowserNotifications.ts | 27 ++++-- .../notificationPermission/index.native.ts | 8 -- .../notificationPermission/index.ts | 33 -------- .../notificationPermission/types.ts | 9 -- .../actions/ConciergeNotificationBanner.ts | 11 --- .../report/EnableNotificationsBanner.tsx | 63 -------------- src/pages/inbox/report/ReportFooter.tsx | 14 +--- .../useShouldShowEnableNotificationsBanner.ts | 36 -------- src/setup/index.ts | 1 - .../ConciergeNotificationBannerTest.ts | 24 ------ tests/unit/EnableNotificationsBannerTest.tsx | 82 ------------------- ...houldShowEnableNotificationsBanner.test.ts | 66 --------------- 24 files changed, 29 insertions(+), 392 deletions(-) delete mode 100644 src/libs/Notification/notificationPermission/index.native.ts delete mode 100644 src/libs/Notification/notificationPermission/index.ts delete mode 100644 src/libs/Notification/notificationPermission/types.ts delete mode 100644 src/libs/actions/ConciergeNotificationBanner.ts delete mode 100644 src/pages/inbox/report/EnableNotificationsBanner.tsx delete mode 100644 src/pages/inbox/report/useShouldShowEnableNotificationsBanner.ts delete mode 100644 tests/actions/ConciergeNotificationBannerTest.ts delete mode 100644 tests/unit/EnableNotificationsBannerTest.tsx delete mode 100644 tests/unit/hooks/useShouldShowEnableNotificationsBanner.test.ts diff --git a/src/ONYXKEYS.ts b/src/ONYXKEYS.ts index 74e4f1d94169..ff79ebaa9adf 100755 --- a/src/ONYXKEYS.ts +++ b/src/ONYXKEYS.ts @@ -568,9 +568,6 @@ const ONYXKEYS = { /** Stores the information if mobile selection mode is active */ RAM_ONLY_MOBILE_SELECTION_MODE: 'mobileSelectionMode', - /** Session-scoped flag: user dismissed the "enable notifications" banner in the Concierge chat */ - RAM_ONLY_HAS_DISMISSED_CONCIERGE_NOTIFICATION_BANNER: 'hasDismissedConciergeNotificationBanner', - NVP_PRIVATE_CANCELLATION_DETAILS: 'nvp_private_cancellationDetails', /** Stores the information about duplicated workspace */ @@ -1587,7 +1584,6 @@ type OnyxValuesMapping = { [ONYXKEYS.ADD_NEW_PERSONAL_CARD]: OnyxTypes.AddNewPersonalCard; [ONYXKEYS.ASSIGN_CARD]: OnyxTypes.AssignCard; [ONYXKEYS.RAM_ONLY_MOBILE_SELECTION_MODE]: boolean; - [ONYXKEYS.RAM_ONLY_HAS_DISMISSED_CONCIERGE_NOTIFICATION_BANNER]: boolean; [ONYXKEYS.DUPLICATE_WORKSPACE]: OnyxTypes.DuplicateWorkspace; [ONYXKEYS.COPY_POLICY_SETTINGS]: OnyxTypes.CopyPolicySettings; [ONYXKEYS.NVP_FIRST_DAY_FREE_TRIAL]: string; diff --git a/src/components/Banner.tsx b/src/components/Banner.tsx index ad2ca1595e65..f652653f910f 100644 --- a/src/components/Banner.tsx +++ b/src/components/Banner.tsx @@ -53,9 +53,6 @@ type BannerProps = { /** Callback called when pressing the button */ onButtonPress?: () => void; - - /** Custom action content rendered in the right side of the banner. Overrides the configured `shouldShowButton` when provided. */ - children?: React.ReactNode; }; function Banner({ @@ -67,7 +64,6 @@ function Banner({ onButtonPress, containerStyles, textStyles, - children, shouldRenderHTML = false, shouldShowIcon = false, shouldShowCloseButton = false, @@ -122,15 +118,14 @@ function Banner({ ))} - {children ?? - (shouldShowButton && ( -