Skip to content

Typo in computation of dist_ref? #7

@xiaoxiao112233

Description

@xiaoxiao112233

Hi, there is a typo in this line:

dist_ref = ((points_for_warp.squeeze(1) - rays_o[val_ray_inside_inds]) / rays_o[val_ray_inside_inds])[..., 0].detach()

I think it should be modified as follows:

dist_ref = ((points_for_warp.squeeze(1) - rays_o[val_ray_inside_inds]) / rays_d[val_ray_inside_inds])[..., 0].detach()

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions