You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the Seeding Input form still makes use of the ErrorBannerComponent. However, the merging of #622 means that these instances need to be removed and the page adequately updated with new data variables to handle the newer BannerComponent.
It's also necessary to consider what new constants need to be added to the BannerMessageConstants.js specifically for the Seeding Input form.
Here are the necessary changes to complete this issue:
Should the banner be closed by pressing an 'X' or should it be timeout based? Whatever is decided should be consistent in all pages,
Remove the ErrorBannerComponent from the page.
Import the BannerComponent into the page (simply add it to the Vue instance in the page).
Add the necessary data variables to support
Update pre-existing functions to make the BannerComponent visible, give the correct object, and handle visibility changes.
Remove the banner we're using under the Seeding Input's title. This can be found on lines #4 and ends on line #12.
Desired Design
Currently the Seeding Input form still makes use of the
ErrorBannerComponent. However, the merging of #622 means that these instances need to be removed and the page adequately updated with new data variables to handle the newerBannerComponent.It's also necessary to consider what new constants need to be added to the BannerMessageConstants.js specifically for the Seeding Input form.
Here are the necessary changes to complete this issue:
ErrorBannerComponentfrom the page.BannerComponentinto the page (simply add it to the Vue instance in the page).BannerComponentvisible, give the correct object, and handle visibility changes.